TCP rate sample proposal #33
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cawka
pushed a commit
to named-data-ndnSIM/ns-3-dev
that referenced
this pull request
Feb 11, 2019
* Extend lte enb phy:mac, rlc and pdcp * Psc dev d2d merge cycle2 * Psc dev d2d merge cycle3 *lte:EPC activate/deactivate Sidelink bearer and start/stop discovery *lte:UE NAS activate/deactivate SL bearer and start/stop discovery One of the major change is done to Send function. Now before sending the packet both in Active and OFF states it checks if there is a Sidelink bearer. If there is, it uses Sidelink bearer to forward the packet. *lte: update SAP between UE NAS and UE RRC *lte: Code style fixed as per ns-3 *lte:eNB Mac SAP update for incoverge discovery. Two SAPs updated: SAP between eNB MAC and RRC; eNB Mac and schedulers *lte:update eNB Phy,MAC and RRC for incoverage discovery and Tx SIB19 *lte:eNB limit frame number to 1024 *lte:update schedulers after fixing frame number to 1024 Every scheduler maintains a map m_allocationMaps to keep track of UE scheduled in certain subframe and frame number(sfnSf). Before frame number were not limited to 1024, thus sfnSf was always unique. Now we need remove the old entry with the same sfnSf number we want to insert, since, the combination can repeat after 10 msec of simulation *lte:fix typo *lte:Added code for incoverge discovery and fixed code style *lte:Keep track of discovery TB index and their decodification *lte:Equality operator overload in SlPreconfigDiscPool-code style fix *lte:Initialize state variables as per 7.1 of TS36.322 For Sidelink STCH RLC state variable initially set to the SN of the first received UMD PDU. Also added the attributes to configure channel type and size of RLC reordering window *lte:update UE SAPs between RRC and MAC, RRC and PHY *lte: Merge UE RRC Created new file for LteSlUeRrc class *lte:UE MAC informs UE PHY about change of timings and Disc apps *lte:Merge UE MAC *lte:Merge UE PHY *lte:Merge Sidelink UE power control code *lte:Add structers for Sidelink Tx and RX Stats *lte:update remaining schedulers after fixing frame number to 1024 Every scheduler maintains a map m_allocationMaps to keep track of UE scheduled in certain subframe and frame number(sfnSf). Before frame number were not limited to 1024, thus sfnSf was always unique. Now we need remove the old entry with the same sfnSf number we want to insert, since, the combination can repeat after 10 msec of simulation *lte:eNB RRC small code style correction *lte:UE MAC notified by UE PHY about Sidelink activation *lte:Merge LteSpectrumPhy *lte:Add vector to store Sidelink destinations *lte:Merge LteHelper *lte:Merge LteStatsCalculator *lte:Merge MacStatsCalculator *lte:Merge PhyRxStatsCalculator and PhyTxStatsCalculator *lte:Add Sidelink interference model and chunk processor *lte:Add Sidelink round robin scheduler *lte:Change propagation model in Wraparound test and fix code style I changed the propagation model to remove lte module dependency on psc module *lte:stop serialization/deserialization of Sidelink info Added code to stop the simulation upon serialization/deserialization of unimplemented sidelink rrc header. I also need to initialize m_haveSlCommConfig and m_haveSlDiscConfig in the constructor of RrcConnectionReconfigurationHeader class to avoid random initialization of these variables upon deserialization of existing header. The random initialization was causing some lte tests to fail. *lte:Notify MAC about SL after setting SAP *lte:Uncomment function call to ActivateSidelinkBearer *lte:Trace path correction for Sidelink traces *lte:Let eNB to receive Sidelink signals *lte:UE MAC should include hopping info in Sidelink information msg *lte:Configure the SL SIMO gain upon the activation of SL *lte:Use SL phy to set Disc ReTx *lte:Improve logging *lte:Merge cycle 3 first review updates *lte:Move rrc-sap methods to convert TxProbability to Disc pool class Updated the doxygen of SetTxProbability function and moved TxProbabilityFromInt and TxProbabilityAsInt to SidelinkDiscResourcePool class. I moved them because by design, example scripts do not access SAP methods directly. In this case, discovery examples call TxProbabilityFromInt to configure the tx probability of a pool. I also plan to move other static functions of rrc-sap to other classes if possible. *lte:Add NIST D2D WNS3 2017 examples *lte:Remove attribute to set Sidelink MCS In Sidelink MCS is specified while configuring the pool *lte:Rename test-lte-sidelink-scen-pool to test-sidelink-comm-pool *lte:Remove dead code *lte:eNB should notify scheduler about sidelink destinations *lte: Enable eNB component carrier manager to handle sidelink BSR *lte:Add getter methods for sidelink comm resource pool factory *lte:++currentPeriod index before comparing to last period index currentPeriod starts from 0 therefore, we should increment it before comparing it to the last period index. *lte:Disable logs *lte:Improve Unit test for sidelink comm pool *lte:Add tests for SL Disc pool and in-coverage communication *lte:Add documentation for sidelink tests *lte:Improve comment *lte:Avoid creating separate DIR for executable files of SL examples I could not run the examples directly from the root folder. After doing this there was no separate directory for the executables of Sidelink examples in build/src/lte/examples, which made it possible to run examples directly from root folder. *lte:Correctly estimate last SC period to handle roll over on frame 0 We returned back to the original logic to assign currentPeriod = -1 upon roll over. The new change is related to the correct computation of the last SC period. It takes into account the configured offset and subtracting 1 from the computed value, since, the currentPeriod starts from 0. *lte:Add check to confirm if RBs computed for Discovery are contiguous *lte:Add test case to check Disc RB assignment and update test doc *lte:Fix code style *lte:Rename function SetSlTxGain to SetSlRxGain *lte:Remove unnecessary NIST prifix *lte:Set DiscPrbNum = 1 *Move all psc Propagation models to buildings module Psc3gppPropagationLoss model renamed to Hybrid3gppPropagationLossModel and HybridPropagationLossModel renamed to OutdoorToIndoorPropagationLossModel *psc:Update examples after moving propg models *psc:Add example-to-run.py *lte:path correction for D2D examples *lte:Init uninitialized variable to solve optimized mode build fail *Merge cycle 3 second review *lte:Update attributes description of iTRP and KTRP *lte:Fix max seq length for hopping func and type of hoppingParameter *Add NIST disclaimer for edited files *Buildings:remove unused functions *lte:Fix doxygen and code style *lte:Add disclaimer to NIST bash scripts *Start from LSB of bitset for bitmap and fix RB index for hoppinginfo1 *lte:Fix bitmap in D2D examples *lte:Update bitmaps in Sidelink tests * Psc devel d2d doc (#29) * buildings:Add documentation for 3GPP aligned pathloss models * lte:Add design and user documentation for Sidelink * buildings:Review update 3GPP aligned pathloss models * lte:Review update Sidelink design documentation * lte:Review update Sidelink tests documentation * lte:Review update Sidelink user documentation * lte:Clean D2D wns3 examples (#31) * lte:Clean D2D wns3 examples * lte: No need of remote host if the communication is just between UEs * psc:Move examples to lte module (#30) I removed example-pathloss-trace because the use of the trace Hybrid3gppPathlossValue of Hybrid3gppPropagationLossModel is already covered by the two examples added to lte * Fix ctrl bitmap in Sync bash script and change propg model * New simple d2d examples (#32) * lte:Remove SlPhyTransmission trace This trace could be confusing for the users as, one can not determine the time of SL transmission on the basis of SL-DCI from the eNB. It depends on the SC period * lte:Make the carrierFreq variable type consistent * lte:Improve the header of PSCCH MAC trace * lte:Add NS logs to ease the debugging * lte:Remove typos * lte:Neglect the grant if there is no data to send * lte:Improve the if statement to avoid the Rx of SL signals at the eNB * lte:Add new simple Sidelink examples and their documentation * lte:Correct trace name * lte:Impove new d2d examples * lte:use UintegerValue to set the attribute of type unit * lte:Unix line endings * lte:Use LteSlDiscPreconfigPoolFactory for out-of-coverage scenario
tomhenderson
pushed a commit
that referenced
this pull request
Jul 20, 2019
Also, attempt to fix the issues listed in #33
tomhenderson
pushed a commit
that referenced
this pull request
Jul 20, 2019
wifi: Misc fixes and code cleanup Closes #45, #33, and #27 See merge request nsnam/ns-3-dev!56
Member
Author
|
this pull request went to GitLab.com |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.