Feature/allow auto-nilled optionals and closures #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dani-hengl
requested changes
Feb 23, 2024
| } | ||
|
|
||
| // Prepare parameter string, auto-nil for optional values | ||
| let defaultValue = (typeAnnotationText.contains("?") || typeAnnotationText.contains("= nil")) ? " = nil" : "" |
There was a problem hiding this comment.
@Lutzifer I woudl also like to have your opionion on that.
I understand that this solves a problem for one of our projects. With the change regarding closures i am pretty fine, but regarding the "auto-nil"-defaultvalue i am not sure if that always makes sense or creates some kind of trap for us as an uninitialized value is not complained anymore as soon as it is optional
There was a problem hiding this comment.
I second that.
- restore the original test, we should not have to change this to ensure backwards-compatibilty
- add a new test that documents what changes we need
- implement the macro so that both cases are successfull
|
closing this for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this resolves a problem in one of our projects.