Skip to content

Conversation

@patrickavs
Copy link
Contributor

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR converts the test suite from XCTest to Swift Testing framework, updating both the test implementation and package dependencies to support the new testing approach.

  • Replaces XCTest imports and class-based tests with Swift Testing's @Suite and @Test annotations
  • Updates test method signatures to remove throws declarations and qualify macro testing calls
  • Upgrades MacroTester and SwiftSyntax dependencies to versions compatible with Swift Testing

Reviewed Changes

Copilot reviewed 2 out of 6 changed files in this pull request and generated 2 comments.

File Description
Tests/MemberwiseInitializerTests/MemberwiseInitializerTests.swift Converts XCTest-based test class to Swift Testing struct with @suite and @test annotations
Package.swift Updates MacroTester and SwiftSyntax dependencies to newer versions supporting Swift Testing

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines 13 to 17
MacroTester.testMacro(macros: testMacros)
}

func testMemberwiseInitializerWithConstant() throws {
testMacro(macros: testMacros)
@Test func memberwiseInitializerWithConstant() {
MacroTester.testMacro(macros: testMacros)
Copy link

Copilot AI Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function calls have inconsistent indentation. They should align with the standard 2-space indentation used elsewhere in the file instead of 6 spaces.

Copilot uses AI. Check for mistakes.
func testMemberwiseInitializerWithConstant() throws {
testMacro(macros: testMacros)
@Test func memberwiseInitializerWithConstant() {
MacroTester.testMacro(macros: testMacros)
Copy link

Copilot AI Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function calls have inconsistent indentation. They should align with the standard 2-space indentation used elsewhere in the file instead of 6 spaces.

Suggested change
MacroTester.testMacro(macros: testMacros)
MacroTester.testMacro(macros: testMacros)

Copilot uses AI. Check for mistakes.
@Lutzifer Lutzifer merged commit 97bc5a4 into main Sep 30, 2025
2 checks passed
@Lutzifer Lutzifer deleted the convert_to_swift_testing branch September 30, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants