Skip to content

Expose smallest subnormal constant and add tests for consts #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2025
Merged

Expose smallest subnormal constant and add tests for consts #117

merged 1 commit into from
Jul 23, 2025
+32 −15

Conversation

juntyr
Copy link
Contributor

@juntyr juntyr commented Jul 20, 2025 •
edited
Loading

  • exposes SLEEF_QUAD_DENORM_MIN as smallest_subnormal
  • renames min_value (SLEEF_QUAD_MIN) to smallest_normal (since the name is bound to bite people, past myself included)
  • adds tests for the exposed constants

@juntyr juntyr changed the title Expose smallest subnormal and test consts Expose smallest subnormal constant and add tests for consts Jul 20, 2025
ngoldbaum
ngoldbaum approved these changes Jul 21, 2025
View reviewed changes
Copy link
Member

@ngoldbaum ngoldbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juntyr
Copy link
Contributor Author

juntyr commented Jul 23, 2025

@SwayamInSync I've rebased this PR - it should be ready to go now

@SwayamInSync SwayamInSync merged commit 6b5dbb2 into numpy:main Jul 23, 2025
6 checks passed
@SwayamInSync
Copy link
Member

Thanks @juntyr

@juntyr juntyr deleted the finfo-consts branch July 23, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngoldbaum ngoldbaum ngoldbaum approved these changes

Assignees
No one assigned
Labels
numpy_quaddtype
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juntyr @SwayamInSync @ngoldbaum