Minimal / simple implementation of SQLite-backed history

.gitignore

@@ -1,5 +1,6 @@
 target/
 history.txt
+history.sqlite3
 .DS_Store
 target-coverage/
 tarpaulin-report.html

Cargo.toml

@@ -27,6 +27,8 @@ strip-ansi-escapes = "0.1.1"
 strum = "0.24"
 strum_macros = "0.24"
 fd-lock = "3.0.3"
+rusqlite = { version = "0.27.0", optional = true, features = ["bundled"] }
+serde_json = { version = "1.0.79", optional = true }
 
 [dev-dependencies]
 tempfile = "3.3.0"
@@ -36,3 +38,4 @@ rstest = "0.12.0"
 [features]
 system_clipboard = ["clipboard"]
 bashisms = []
+sqlite = ["rusqlite", "serde_json"]

src/engine.rs

@@ -320,7 +320,6 @@ impl Reedline {
         let history: Vec<_> = self
             .history
             .iter_chronologic()
-            .cloned()
             .enumerate()
             .collect();
 

src/history/base.rs

@@ -1,5 +1,4 @@
 use crate::core_editor::LineBuffer;
-use std::collections::vec_deque::Iter;
 
 /// Browsing modes for a [`History`]
 #[derive(Debug, Clone, PartialEq, Eq)]
@@ -20,7 +19,7 @@ pub trait History: Send {
     fn append(&mut self, entry: &str);
 
     /// Chronologic interaction over all entries present in the history
-    fn iter_chronologic(&self) -> Iter<'_, String>;
+    fn iter_chronologic(&self) -> Box<dyn DoubleEndedIterator<Item=String> + '_>;
 
     /// This moves the cursor backwards respecting the navigation query that is set
     /// - Results in a no-op if the cursor is at the initial point

src/history/file_backed.rs

@@ -68,8 +68,8 @@ impl History for FileBackedHistory {
         self.reset_cursor();
     }
 
-    fn iter_chronologic(&self) -> Iter<'_, String> {
-        self.entries.iter()
+    fn iter_chronologic(&self) -> Box<(dyn DoubleEndedIterator<Item = String> + '_)> {
+        Box::new(self.entries.iter().map(|e| e.to_string()))
     }
 
     fn back(&mut self) {
@@ -121,7 +121,6 @@ impl History for FileBackedHistory {
         self.iter_chronologic()
             .rev()
             .filter(|entry| entry.contains(search))
-            .cloned()
             .collect::<Vec<String>>()
     }
 

src/history/mod.rs

@@ -1,5 +1,9 @@
 mod base;
 mod file_backed;
+#[cfg(feature="sqlite")]
+mod sqlite_backed;
+#[cfg(feature="sqlite")]
+pub use sqlite_backed::SqliteBackedHistory;
 
 pub use base::{History, HistoryNavigationQuery};
-pub use file_backed::{FileBackedHistory, HISTORY_SIZE};
+pub use file_backed::{FileBackedHistory, HISTORY_SIZE};