Skip to content

Revert resize handling removal #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sholderbach wants to merge 3 commits into from
Closed

Revert resize handling removal #478

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fbcc1c3
Revert "remove anims and resize repaint (#451)"
sholderbach Sep 12, 2022
1f12708
Remove animations again
sholderbach Sep 12, 2022
e2b4408
Fix accidental always repaint
sholderbach Sep 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix accidental always repaint
  • Loading branch information
@sholderbach
sholderbach committed Sep 13, 2022
commit e2b4408d47513a415f666b4eb33f9376bccd79b6
2 changes: 0 additions & 2 deletions src/engine.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,8 +504,6 @@ impl Reedline {
if let Some(ec) = last_edit_commands {
reedline_events.push(ReedlineEvent::Edit(ec));
}
} else if !self.painter.exceeds_screen_size() {
reedline_events.push(ReedlineEvent::Repaint);
};

for event in reedline_events.drain(..) {
Expand Down
7 changes: 0 additions & 7 deletions src/painting/painter.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,13 +81,6 @@ impl Painter {
self.screen_height() - self.prompt_start_row
}

/// Check if the currently painted content exceeds the size of the screen
/// and thus should not be repainted without reason (disable animation
/// repaint)
pub(crate) fn exceeds_screen_size(&self) -> bool {
self.large_buffer
}

/// Sets the prompt origin position and screen size for a new line editor
/// invocation
///
Expand Down