Skip to content

enable deleting history items with keybinding #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
samlich wants to merge 6 commits into
base: main
Choose a base branch
from
Open

enable deleting history items with keybinding #567

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ae0b54f
enable deleting history items with keybinding
samlich Apr 6, 2023
4a4af76
review
samlich Apr 12, 2023
e6e84c8
clear buffer when not in history mode
samlich Apr 12, 2023
883b4c8
add comment about move_to_line_end
samlich Apr 12, 2023
baeecc2
oops
samlich Apr 12, 2023
55af00e
delete from file on file-backed history
samlich Apr 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add comment about move_to_line_end
  • Loading branch information
@samlich
samlich committed Apr 29, 2023
commit 883b4c8b5b29a8989830b16f832b265b79898d6c
3 changes: 2 additions & 1 deletion src/engine.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1117,7 +1117,7 @@ impl Reedline {
{
Some(Ok(())) => {
self.update_buffer_from_history();
// TODO: are these needed/correct?
// Move to end of first line, see `Self::previous_history()`.
self.editor.move_to_start(UndoBehavior::HistoryNavigation);
self.editor
.move_to_line_end(UndoBehavior::HistoryNavigation);
Expand Down Expand Up @@ -1188,6 +1188,7 @@ impl Reedline {
.back(self.history.as_ref())
.expect("todo: error handling");
self.update_buffer_from_history();
// Move to end of *first* line, so that pressing up again goes directly to previous item.
self.editor.move_to_start(UndoBehavior::HistoryNavigation);
self.editor
.move_to_line_end(UndoBehavior::HistoryNavigation);
Expand Down