Skip to content

Fix shift selection (selecting to the left includes character to the right) #926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
collinmurch wants to merge 2 commits into from
Closed

Fix shift selection (selecting to the left includes character to the right) #926

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d636191
Fix shift selection regression (selecting to the left includes charac…
collinmurch Jun 28, 2025
b4b57b3
rustfmt
collinmurch Jun 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
rustfmt
  • Loading branch information
@collinmurch
collinmurch committed Jun 28, 2025
commit b4b57b3f2e18c3bf7eb8656931fff6c3d1e5cd94
11 changes: 5 additions & 6 deletions src/core_editor/editor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1358,14 +1358,13 @@ mod test {

#[test]
fn test_shift_arrow_selection_regression() {
// Test the specific issue from #893: shift+arrow should select only one character
let mut editor = editor_with("123456789");
editor.line_buffer.set_insertion_point(3); // After "3"
editor.selection_anchor = Some(3); // Start selection at position 3

// Simulate shift+left (move left with selection)
editor.run_edit_command(&EditCommand::MoveLeft { select: true });

// Should select only the character '3' (position 2-3), not '34'
assert_eq!(editor.get_selection(), Some((2, 3)));
}
Expand All @@ -1375,12 +1374,12 @@ mod test {
let mut editor = editor_with("hello world");
editor.line_buffer.set_insertion_point(5); // After "hello"
editor.selection_anchor = Some(0); // From start

// Copy operation
editor.copy_selection_to_cut_buffer();
assert_eq!(editor.cut_buffer.get().0, "hello");
// Cut operation

// Cut operation
editor.line_buffer.set_insertion_point(11); // At end
editor.selection_anchor = Some(6); // From " world"
editor.cut_selection_to_cut_buffer();
Expand Down