Fix: Extend the server proxy preset to also fetch SSG NuxtIslands#815
Merged
chakAs3 merged 1 commit intonuxt-modules:mainfrom Nov 28, 2024
Merged
Conversation
👷 Deploy request for nuxt-storybook pending review.Visit the deploys page to approve it
|
Collaborator
|
Thanks for the PR! Could you please shortly explain how this nuxt proxy works? I was never able to really unravel why it is needed in the first place. Could you also please add a story that uses an island in the |
Collaborator
I used the proxy to serve files from the Nuxt dev server (port 3000) since Storybook runs on a separate dev server. This setup allowed components like NuxtImage and page routing to function properly. However, I wonder if there’s a better approach to consolidate everything into a single dev server. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Description
This PR extends the preset for the server proxy, to also allow the fetching of NuxtIsland components from the dev server.
Standalone stories for NuxtIslands work fine. But when you have a component that has a NuxtIsland component in it, it won't render (properly) because it can't find the server only parts in the Storybook server. With this PR those routes are exposed and make the stories render.
There's one thing left to make NuxtIsland's work without any user changes needed: a Suspense wrapper, but I wasn't too sure if/where that should be enabled by default.
Reproduction stories
main...brandondv:nuxtjs-storybook:feature/child-nuxt-island-stories