Error: Cannot find module 'typescript'

[Revadike]

@antfu sadly v0.5.3 brought this bug back.

Originally posted by @Revadike in #485 (comment)

[antfu]

Can you give a new reproduction? We didn't change much about that part

[Revadike]

IDK what changed, very odd, but now even v0.5.2 doesn't work anymore. It may be related to one of your dependencies? I believe it happened after doing yarn upgrade.

Here is the stack:

Error: Cannot find module 'typescript'
Require stack:
- /node_modules/@typescript-eslint/typescript-estree/dist/convert.js
- /node_modules/@typescript-eslint/typescript-estree/dist/ast-converter.js
- /node_modules/@typescript-eslint/typescript-estree/dist/parser.js
- /node_modules/@typescript-eslint/typescript-estree/dist/index.js
- /node_modules/eslint-plugin-import-x/lib/utils/parse.js
- /node_modules/eslint-plugin-import-x/lib/utils/export-map.js
- /node_modules/eslint-plugin-import-x/lib/utils/index.js
- /node_modules/eslint-plugin-import-x/lib/rules/consistent-type-specifier-style.js
- /node_modules/eslint-plugin-import-x/lib/index.js
    at Module._resolveFilename (node:internal/modules/cjs/loader:1152:15)
    at Module._load (node:internal/modules/cjs/loader:993:27)
    at c._load (node:electron/js2c/node_init:2:13801)
    at Module.require (node:internal/modules/cjs/loader:1240:19)
    at require (node:internal/modules/helpers:179:18)
    at Object.<anonymous> (/node_modules/@typescript-eslint/typescript-estree/dist/convert.js:30:25)
    at Module._compile (node:internal/modules/cjs/loader:1373:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1432:10)
    at Module.load (node:internal/modules/cjs/loader:1215:32)
    at Module._load (node:internal/modules/cjs/loader:1031:12)

checking npm ls gives:

└─┬ @nuxt/eslint@0.5.5
  ├─┬ @nuxt/eslint-config@0.5.5
  │ ├─┬ @typescript-eslint/eslint-plugin@8.4.0
  │ │ └─┬ @typescript-eslint/type-utils@8.4.0
  │ │   └── @typescript-eslint/typescript-estree@8.4.0 deduped
  │ ├─┬ @typescript-eslint/parser@8.4.0
  │ │ └── @typescript-eslint/typescript-estree@8.4.0
  │ └─┬ eslint-plugin-import-x@4.1.1
  │   └── @typescript-eslint/typescript-estree@8.4.0 deduped
  └─┬ @nuxt/eslint-plugin@0.5.5
    └─┬ @typescript-eslint/utils@8.4.0
      └── @typescript-eslint/typescript-estree@8.4.0 deduped
      ```

[Revadike]

@antfu Check this: https://github.com/Revadike/reproduction

[antfu]

Seems to introduced by this line: https://github.com/un-ts/eslint-plugin-import-x/blob/34e1334a907d56150133bf338174a172ce89173d/src/utils/parse.ts#L3

You might want to report to https://github.com/un-ts/eslint-plugin-import-x

[Revadike]

Seems to introduced by this line: un-ts/eslint-plugin-import-x@34e1334/src/utils/parse.ts#L3

You might want to report to un-ts/eslint-plugin-import-x

Hmm, I checked their docs and it seems the difference between the plain js and ts version is the use of @typescript-eslint/parser. Are you using this? Always, or just with ts?

[antfu]

Always. Because it's about import and not TS specific. It's the side-effect they introduced.

[SukkaW]

Was bought to here by un-ts/eslint-plugin-import-x@ac11f62#r146221700

Is it possible that typescript-estree declares typescript as its peer dependency? But it is an optional peer dependency which should not cause any problem.

[SukkaW]

Might wanna raise the issue to typescript-eslint instead. It seems that importing withoutProjectParserOptions alone will also run loads of side effects that require typescript.

[antfu]

Importing the module (https://unpkg.com/browse/@typescript-eslint/typescript-estree@8.4.0/dist/index.js) end up importing all the modules in typescript-estree, which end up with the side-effect that importing typescript - maybe they can do a pure submodule like @typescript-eslint/typescript-estree/withoutProjectParserOptions?

[Revadike]

🎉

[SukkaW]

@Revadike @antfu eslint-plugin-import-x@4.2.0 is just released with the workaround included!