Skip to content

fix: do not start new LSP client when navigating to flutter dependency file #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sidlatau merged 2 commits into from
Jul 1, 2025
Merged

fix: do not start new LSP client when navigating to flutter dependency file #483

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
130ad29
refactor: rename and move is_flutter_dependency_path method
sidlatau Jun 29, 2025
ce7e89a
fix: do not start new lsp client for flutter dependency
sidlatau Jun 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: do not start new lsp client for flutter dependency
  • Loading branch information
@sidlatau
sidlatau committed Jun 29, 2025
commit ce7e89a64166eeecc8d7576632295d542c0b722e
14 changes: 8 additions & 6 deletions lua/flutter-tools/lsp/init.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,12 +170,14 @@ end
function M.get_project_root_dir()
local conf = require("flutter-tools.config")
local current_buffer_path = path.current_buffer_path()
local root_path = lsp_utils.is_valid_path(current_buffer_path)
and path.find_root(conf.root_patterns, current_buffer_path)
or nil

if root_path ~= nil then return root_path end

-- Check if path is flutter dependency. For dependencies we do not
-- search for a root directory as they are not projects.
if not path.is_flutter_dependency_path(current_buffer_path) then
local root_path = lsp_utils.is_valid_path(current_buffer_path)
and path.find_root(conf.root_patterns, current_buffer_path)
or nil
if root_path ~= nil then return root_path end
end
local client = lsp_utils.get_dartls_client()
return client and client.config.root_dir or nil
end
Expand Down
Loading