Skip to content

[Fix] nvm_alias: ensure lts/-1 returns the one before lts/*#2462

Merged
ljharb merged 1 commit intonvm-sh:masterfrom
RodEsp:patch-1
Mar 11, 2021
Merged

[Fix] nvm_alias: ensure lts/-1 returns the one before lts/*#2462
ljharb merged 1 commit intonvm-sh:masterfrom
RodEsp:patch-1

Conversation

@RodEsp
Copy link
Contributor

@RodEsp RodEsp commented Mar 11, 2021

Title says it all.

fixes #2461

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think we need to modify the existing tests so we have a regression test for this, though :-)

@ljharb
Copy link
Member

ljharb commented Mar 11, 2021

Actually it looks like the failing tests are the ones that were just written incorrectly in the first place.

@ljharb
Copy link
Member

ljharb commented Mar 11, 2021

I've rebased and tweaked the tests; let's see if this passes.

@ljharb ljharb changed the title fix: nvm_alias previous lts calculation [Fix] nvm_alias: ensure lts/-1 returns the one before lts/* Mar 11, 2021
@ljharb ljharb added the bugs Oh no, something's broken :-( label Mar 11, 2021
@RodEsp
Copy link
Contributor Author

RodEsp commented Mar 11, 2021

Thank you for taking care of the tests!
I was having a pretty annoying time trying to figure out how to easily fix and run these things locally on my Windows machine haha.

@RodEsp RodEsp requested a review from ljharb March 11, 2021 22:02
@ljharb ljharb merged commit 4da7f10 into nvm-sh:master Mar 11, 2021
@ghost
Copy link

ghost commented Mar 11, 2021

You know, what attracts me most in a person is intelligence and your skills with links, coding all that is fuckn awesome your intelligence in this repository is pure insight and genius. I hope all goes well

@ljharb
Copy link
Member

ljharb commented Mar 11, 2021

thanks! The next release will include this.

@ghost
Copy link

ghost commented Mar 12, 2021

No problem

@RodEsp RodEsp deleted the patch-1 branch March 12, 2021 00:41
@RodEsp
Copy link
Contributor Author

RodEsp commented Mar 29, 2021

Heya @ljharb, would you happen to have a date for the next release?

@ljharb
Copy link
Member

ljharb commented Mar 29, 2021

I don't typically release on any particular schedule. However, v0.38.0 has just been released.

@RodEsp
Copy link
Contributor Author

RodEsp commented Mar 29, 2021

Beautiful, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugs Oh no, something's broken :-(

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lts/-1 alias returns current lts instead of previous lts

2 participants