[Fix] nvm_ls_remote_index_tab: handle long version lists#2581
Merged
ljharb merged 2 commits intonvm-sh:masterfrom Sep 4, 2021
kstolp:fix_long_version_list
Merged
[Fix] nvm_ls_remote_index_tab: handle long version lists#2581ljharb merged 2 commits intonvm-sh:masterfrom kstolp:fix_long_version_list
nvm_ls_remote_index_tab: handle long version lists#2581ljharb merged 2 commits intonvm-sh:masterfrom
kstolp:fix_long_version_list
Conversation
ljharb
approved these changes
Sep 4, 2021
Member
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
I was going to ask for a regression test, but it turns out if i merely update nvm's test mocks, the lists become long enough to trigger this error on travis, and your fix fixes it. Thanks!
(will merge if tests pass)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2578