Skip to content

Fix x-forwarded Headers example #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pakastin wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix x-forwarded Headers example #66

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix x-forwarded Headers example 
At least Chrome sends :authority pseudo header instead of host header, which breaks both this example and express vhost. Hence I added headers.host as well here.
  • Loading branch information
@pakastin
pakastin authored Oct 8, 2021
commit 315b60b4aa9ce8933fc2721192af908a159503e3
8 changes: 5 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,9 +111,11 @@ server.on('request', (req, res) => {
hostname: 'localhost'
port: 9000,
onReq: (req, { headers }) => {
headers['x-forwarded-for'] = req.socket.remoteAddress
headers['x-forwarded-proto'] = req.socket.encrypted ? 'https' : 'http'
headers['x-forwarded-host'] = req.headers['host']
const host = req.headers.host || req.authority.split(':')[0];
headers.host = host;
headers['x-forwarded-for'] = req.socket.remoteAddress;
headers['x-forwarded-proto'] = req.socket.encrypted ? 'https' : 'http';
headers['x-forwarded-host'] = host;
}
}, defaultWebHandler)
})
Expand Down