Find usages add#68
Conversation
|
@xzescha Hey there! 👋 I noticed your branch name " |
|
@yegor256 could you please review this and my other PR. Hope so, they're valid and ready to merge! |
|
@xzescha I see most build jobs failing. We can't merge now, see: https://www.yegor256.com/2025/04/19/dont-merge-into-broken-master.html |
…ed outdated versions of IDEA, to try with only new one
…ed outdated versions of IDEA, to try with only new one. Try with different build.gradle
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #68 +/- ##
============================================
- Coverage 35.60% 35.10% -0.50%
+ Complexity 25 19 -6
============================================
Files 13 12 -1
Lines 191 188 -3
Branches 5 17 +12
============================================
- Hits 68 66 -2
Misses 119 119
+ Partials 4 3 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
… another and another
…at directly affects UI, that can't be tested as Unit-tests
|
@yegor256, Done! I've fixed pipelines, added few tests for new funtionality. |
|
@volodya-lombrozo can you please review this? |
volodya-lombrozo
left a comment
There was a problem hiding this comment.
@xzescha Great thanks for the PR. There are lots of valuable changes.
However, I highly recommend you reading Helping others review your changes. Pay attention to:
For example, it's hard to understand what you are trying to solve in this PR. Could you provide a link to the issue, please? Also, a detailed explanation would also greatly help here.
Another important aspect is the PR size. The PR is too big and it seems we are trying to solve many problems at once. Can we split this PR on a few small PRs? It would be better if they were 100~300 lines length.
Added find usages add-on implementation. It's not fully refactored yet, but till tomorrow it'll be fully ready to merge!