Skip to content

obs-outputs: Add mbedTLS support to libRTMP #1360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
compiler-errors wants to merge 9 commits into from
Closed

obs-outputs: Add mbedTLS support to libRTMP #1360

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8ba228f
obs-outputs: Add support for and use mbedTLS for SSL
compiler-errors Jul 3, 2018
abc35b1
obs-outputs: Fix OS-specific mbedTLS cmake rules
compiler-errors Jul 6, 2018
bf82d89
rtmp-services: Change Facebook stream URL to use RTMPS
compiler-errors Jul 4, 2018
748ce31
obs-outputs: Add RTMPS to new network stack
compiler-errors Jul 11, 2018
abfe3c5
obs-outputs: Enable RTMPS, strict cert check by default
compiler-errors Jul 24, 2018
dae47d2
obs-outputs: Load root certs on MacOS/Windows
compiler-errors Jul 25, 2018
e37add8
obs-outputs: Improve mbedTLS support
notr1ch Jul 27, 2018
bd2ec74
obs-outputs: Update CMakeLists for RTMPS support
compiler-errors Jul 27, 2018
06f288b
obs-outputs: Change mbedTLS build options
compiler-errors Jul 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
obs-outputs: Add RTMPS to new network stack
  • Loading branch information
@compiler-errors
compiler-errors committed Jul 11, 2018
commit 748ce319b09a4af63bb5785ad909038e617ab911
8 changes: 4 additions & 4 deletions plugins/obs-outputs/rtmp-windows.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,13 +169,13 @@ static enum data_ret write_data(struct rtmp_stream *stream, bool *can_write,
size_t send_len =
min(latency_packet_size, stream->write_buf_len);

ret = send(stream->rtmp.m_sb.sb_socket,
ret = RTMPSockBuf_Send(&stream->rtmp.m_sb,
(const char *)stream->write_buf,
(int)send_len, 0);
(int)send_len);

@notr1ch notr1ch Jul 11, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to disable low latency mode if using RTMPS. I'm not entirely sure how mbed TLS handles sizing of records, but writing lots of small chunks may result in a high TLS record overhead.

@RytoEX RytoEX Aug 2, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@notr1ch I noticed this comment seemed unresolved. Is this still a concern?

} else {
ret = send(stream->rtmp.m_sb.sb_socket,
ret = RTMPSockBuf_Send(&stream->rtmp.m_sb,
(const char *)stream->write_buf,
(int)stream->write_buf_len, 0);
(int)stream->write_buf_len);
}

if (ret > 0) {
Expand Down