Block Hooks API: Move hooked blocks injection logic #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a similar vein as @tjcafferkey's WordPress#6604, this introduces a new
insert_hooked_blocks_into_rest_responsefilter and adds it to therest_prepare_wp_navigationhook. (Note that this branch is actually based on Tom's; the reason is that it uses at least one function that's introduced there.)This is part of an effort to move code from the Navigation block into Core. Specifically,
insert_hooked_blocks_into_rest_responseis based onblock_core_navigation_insert_hooked_blocks_into_rest_response.Testing instructions:
Preparation: Make sure you're using a Block Theme to test, ideally TT4. Add the following code to your site (e.g. to your theme's
functions.php).wp_navigationpost object for you Navigation menu in your database, make sure that it doesn't have any_wp_ignored_hooked_blockspost meta set. (You can check the latter vianpm run wp-env run cli wp post meta list <postId>.) Otherwise, you'll need to delete said post meta.I will follow up with a Gutenberg PR to make the Navigation block's insertion of hooked blocks conditional. That other PR will have to get merged and sync'd to Core before we can land this change.
Trac ticket: https://core.trac.wordpress.org/ticket/60759
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.