Block Bindings: Allow more generic setting of block attributes (use WP_HTML_Text_Replacement)
#6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment to fix broken test
ockham
changed the title
WP_HTML_Text_Replacement)
ockham
force-pushed
the
try/simplify-block-bindings-replace-html
branch
2 times, most recently
from
b558a5a to
a18e435
Compare
Owner
Author
|
Closing. I've carried over the changes from this PR to WordPress#9469. |
ockham
deleted the
try/simplify-block-bindings-replace-html-use-text-replacement
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on WordPress#9469.
In particular, see WordPress#9469 (comment) for the rationale.
Extend an existing test case so that it would break with the previous implementation of
WP_Block_Bindings_Processor. Then, change the implementation to useWP_HTML_Text_Replacement, which is more "correct", and fixes the broken test.TODO
Add more checks in
replace_rich_text(), per WordPress#9469 (comment):Trac ticket: https://core.trac.wordpress.org/ticket/63840
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.