Skip to content

feat: add redirect request option #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 9, 2024
Merged

feat: add redirect request option #636

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
97bb0b4
Fixed regression of redirect option being passed through to fetch
mitchcapper Sep 23, 2023
25253c5
Merge branch 'main' into fetch_redirect_passthrough_fix_pr
wolfy1339 Apr 8, 2024
c707a63
add back old-redirect option
wolfy1339 Apr 8, 2024
a1f05d8
Merge branch 'main' into fetch_redirect_passthrough_fix_pr
wolfy1339 Apr 9, 2024
8f67558
build: upgrade jest
wolfy1339 Apr 9, 2024
020bfae
fix: mode redirect option to `requestOptions.request`
wolfy1339 Apr 9, 2024
fc9bd43
test: add test for redirect
wolfy1339 Apr 9, 2024
57528c9
fix(deps): bump `@octokit/types`
wolfy1339 Apr 9, 2024
c8c3238
style: prettier
wolfy1339 Apr 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: mode redirect option to requestOptions.request
  • Loading branch information
@wolfy1339
wolfy1339 committed Apr 9, 2024
commit 020bfae62065693be604de5bfb181b264593862a
7 changes: 2 additions & 5 deletions src/fetch-wrapper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,7 @@ import type { EndpointInterface } from "@octokit/types";
import getBuffer from "./get-buffer-response.js";

export default function fetchWrapper(
requestOptions: ReturnType<EndpointInterface> & {
/** A string indicating whether request follows redirects, results in an error upon encountering a redirect, or returns the redirect (in an opaque fashion). Sets request's redirect. */
redirect?: RequestRedirect;
},
requestOptions: ReturnType<EndpointInterface>,
) {
const log =
requestOptions.request && requestOptions.request.log
Expand Down Expand Up @@ -42,7 +39,7 @@ export default function fetchWrapper(
return fetch(requestOptions.url, {
method: requestOptions.method,
body: requestOptions.body,
redirect: requestOptions.redirect,
redirect: requestOptions.request?.redirect,
// Header values must be `string`
headers: Object.fromEntries(
Object.entries(requestOptions.headers).map(([name, value]) => [
Expand Down