Skip to content

chore(deps): update vitest monorepo to v4 (major) #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wolfy1339 merged 3 commits into from
Oct 31, 2025
Merged

chore(deps): update vitest monorepo to v4 (major) #781

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6fda63b
chore(deps): update vitest monorepo to v4
renovate[bot] Oct 30, 2025
80f1d08
fix errors in tests
wolfy1339 Oct 30, 2025
f9ebf60
Please the crappier coverage in vitest 4
wolfy1339 Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Please the crappier coverage in vitest 4
  • Loading branch information
@wolfy1339
wolfy1339 committed Oct 30, 2025
commit f9ebf602a1cc212a33b7a7b38fbfb29924cd775b
15 changes: 12 additions & 3 deletions src/fetch-wrapper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ import type { EndpointInterface, OctokitResponse } from "@octokit/types";

type ContentType = ReturnType<typeof safeParse>;

/* v8 ignore next -- @preserve */
const noop = () => "";

export default async function fetchWrapper(
requestOptions: ReturnType<EndpointInterface>,
): Promise<OctokitResponse<any>> {
Expand Down Expand Up @@ -50,6 +53,8 @@ export default async function fetchWrapper(
// wrap fetch errors as RequestError if it is not a AbortError
} catch (error) {
let message = "Unknown Error";
/* v8 ignore else -- @preserve */
/* vitest coverage bug where it thinks that there is an else */
if (error instanceof Error) {
if (error.name === "AbortError") {
(error as RequestError).status = 500;
Expand All @@ -62,6 +67,7 @@ export default async function fetchWrapper(
// and puts the error message in `error.cause`
// https://github.com/nodejs/undici/blob/e5c9d703e63cd5ad691b8ce26e3f9a81c598f2e3/lib/fetch/index.js#L227
if (error.name === "TypeError" && "cause" in error) {
/* v8 ignore else -- @preserve */
if (error.cause instanceof Error) {
message = error.cause.message;
} else if (typeof error.cause === "string") {
Expand Down Expand Up @@ -152,7 +158,7 @@ async function getResponseData(response: Response): Promise<any> {
const contentType = response.headers.get("content-type");

if (!contentType) {
return response.text().catch(() => "");
return response.text().catch(noop);
}

const mimetype = safeParse(contentType);
Expand All @@ -169,9 +175,12 @@ async function getResponseData(response: Response): Promise<any> {
mimetype.type.startsWith("text/") ||
mimetype.parameters.charset?.toLowerCase() === "utf-8"
) {
return response.text().catch(() => "");
return response.text().catch(noop);
} else {
return response.arrayBuffer().catch(() => new ArrayBuffer(0));
return response.arrayBuffer().catch(
/* v8 ignore next -- @preserve */
() => new ArrayBuffer(0),
);
}
}

Expand Down