Skip to content

[REF] charts: add dataSources to gauge/scorecards#8624

Open
hokolomopo wants to merge 1 commit into
masterfrom
master-scorecard-data-source-adrm
Open

[REF] charts: add dataSources to gauge/scorecards#8624
hokolomopo wants to merge 1 commit into
masterfrom
master-scorecard-data-source-adrm

Conversation

@hokolomopo
Copy link
Copy Markdown
Contributor

Description

The version is 19.4. The charts are entirely occupied by data sources. Well, not entirely... One small chart type still holds out against the data source invaders.

So scorecard and gauge charts are the last chart types that do not use data sources like the other charts. This commit changes it, and make them use data sources as well.

The biggest difference is that now the data sources can result style as well as cell content.

Some other changes:

  • the scorecard/gauge now have the use row X as header as the other charts. It's not great.
  • the ChartLabelRange component was deleted. It was only used once, and had no business logic.

Task: 6180128

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@robodoo
Copy link
Copy Markdown
Collaborator

robodoo commented May 11, 2026

Pull request status dashboard

The version is 19.4. The charts are entirely occupied by data sources.
Well, not entirely... One small chart type still holds out
against the data source invaders.

So scorecard and gauge charts are the last chart types that do not
use data sources like the other charts. This commit changes it, and
make them use data sources as well.

The biggest difference is that now the data sources can result style
as well as cell content.

Some other changes:
- the scorecard/gauge now have the `use row X as header` as the other
charts. It's not great.
- the `ChartLabelRange` component was deleted. It was only used once,
and had no business logic.

Task: 6180128
@hokolomopo hokolomopo force-pushed the master-scorecard-data-source-adrm branch from 4a8997a to 5e0c9a1 Compare May 11, 2026 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants