[REF] charts: add dataSources to gauge/scorecards#8624
Open
hokolomopo wants to merge 1 commit into
Open
Conversation
Collaborator
The version is 19.4. The charts are entirely occupied by data sources. Well, not entirely... One small chart type still holds out against the data source invaders. So scorecard and gauge charts are the last chart types that do not use data sources like the other charts. This commit changes it, and make them use data sources as well. The biggest difference is that now the data sources can result style as well as cell content. Some other changes: - the scorecard/gauge now have the `use row X as header` as the other charts. It's not great. - the `ChartLabelRange` component was deleted. It was only used once, and had no business logic. Task: 6180128
4a8997a to
5e0c9a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
The version is 19.4. The charts are entirely occupied by data sources. Well, not entirely... One small chart type still holds out against the data source invaders.
So scorecard and gauge charts are the last chart types that do not use data sources like the other charts. This commit changes it, and make them use data sources as well.
The biggest difference is that now the data sources can result style as well as cell content.
Some other changes:
use row X as headeras the other charts. It's not great.ChartLabelRangecomponent was deleted. It was only used once, and had no business logic.Task: 6180128
review checklist