[IMP] sheet: add background color to sheet#8646
Open
hokolomopo wants to merge 1 commit into
Open
Conversation
Collaborator
|
|
hokolomopo
commented
May 12, 2026
Comment on lines
+218
to
+222
| const baseGridColor = "#CECFCF"; | ||
| const background = this.getBackgroundColor(renderingContext); | ||
| const blendedGridColor = blendColors(baseGridColor + "aa", background + "50"); | ||
| ctx.strokeStyle = setColorAlpha(blendedGridColor, 1); | ||
| ctx.lineWidth = thinLineWidth; |
Contributor
Author
There was a problem hiding this comment.
Bend the color a bit with the background so it's less shocking of non-white background color. Color was picked so it stays the same on a white background.
Still not great on colored background tho. Probably should tweak it a bit, and have a different color on high-contrast background.
But for obvious reasons, I'm not great with colors 😔
Contributor
|
@hokolomopo : need a rebase (probably because of the dark mode, as the grid doesn't seem to work for the dark mode ...) |
hokolomopo
force-pushed
the
master-sheet-background-adrm
branch
from
601b2ae to
14ba35d
Compare
This commit adds the possibility to set the background color of a sheet. There was also a few issue with the sheet tab color, the color was not added to the custom colors and the color picker didn't have a color selected. Task: 6209932
hokolomopo
force-pushed
the
master-sheet-background-adrm
branch
from
14ba35d to
16622e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This commit adds the possibility to set the background color of a sheet.
There was also a few issue with the sheet tab color, the color was not added to the custom colors and the color picker didn't have a color selected.
Task: 6209932
review checklist