Skip to content

Conversation

mikayel
Copy link
Contributor

@mikayel mikayel commented Feb 23, 2016

Version bump for react-router

Version bump for react-router
@mikayel
Copy link
Contributor Author

mikayel commented Feb 23, 2016

For avoiding npm install warnings.
I have tested here https://github.com/mikayel/react-cv and it is fine.

@seanadkinson
Copy link
Contributor

No other changes needed to support 2.x? Nice.

Let's bump to 0.5 for this change though, since someone upgrading this library by a minor version bump shouldn't have to upgrade react-router by a major version.

Can you change this to 0.5.0, confirm nothing needs to change for [email protected], and then I'll merge and release? Thanks!

@mikayel
Copy link
Contributor Author

mikayel commented Mar 1, 2016

I have made the changes.

@seanadkinson
Copy link
Contributor

Thanks

seanadkinson added a commit that referenced this pull request Mar 1, 2016
@seanadkinson seanadkinson merged commit 3383864 into odysseyscience:master Mar 1, 2016
@seanadkinson
Copy link
Contributor

Pushed v0.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants