Add support for placeholders in chunk names #20
Conversation
|
Looks good. Can you add something to the |
|
Done, tell me if it's clear enough |
index.js
Outdated
| module.exports.pitch = function(remainingRequest) { | ||
| this.cacheable && this.cacheable(); | ||
| var query = loaderUtils.parseQuery(this.query); | ||
| var chunkName = loaderUtils.interpolateName(this, 'routes/' + query.name, { |
There was a problem hiding this comment.
For backwards compatibility, should we check the existence of a [ in the name? Using the example from the readme, if an existing user had ?name=user, their behavior would now change. But maybe that doesn't matter. Thoughts?
There was a problem hiding this comment.
I'm thinking maybe automatically putting the chunks in a subfolder by default is a bad idea, would maybe be better to just leave behavior unchanged but mention how to do that in the README?
There was a problem hiding this comment.
Yeah, that would be better.
|
@seanadkinson done |
|
Good stuff @Anahkiasen. Let me pull this down and do some quick testing, and as long as its backwards compatible I'll push an update. |
|
Published |
2 participants
Closes #19