Interrupt V8 when frontend connects. #25
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change introduces experimental v8-inspector support. This brings the DevTools debug protocol allowing Node.js to be debugged with Chrome DevTools native, or through other debuggers supporting that protocol. Partial WebSocket support, to the extent required by DevTools, is included. This is derived from the implementation in Blink. This code is currently behind a --with-inspector configure flag.
Pick up v8 inspector from [1]. This is the standalone version of the devtools debug protocol. [1] https://github.com/repenaxa/v8_inspector/commit/6dd87365
|
|
||
| void Run() override { | ||
| agent_->SetConnected(connected_); | ||
| int pending = agent_->SafeSetAndGetField(agent_->pending_connected_, |
There was a problem hiding this comment.
I don't think this is right. The only way to implement it correctly is to serialize connect/disconnect messages with the actual commands, i.e. to reuse the message queue for connect/disconnect. That way input such as ", message 1, message 2, message 3, , , message 10, message 11, message 12, " would be processed in order.
ofrobots
force-pushed
the
v8-inspector
branch
6 times, most recently
from
73b9c32 to
0af8865
Compare
ofrobots
force-pushed
the
v8-inspector
branch
6 times, most recently
from
09efcf8 to
10c9ffe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interrupt V8 to process frontend connection
@pavelfeldman - please take a look