Address @bnoordhuis review comments. #41
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pick up v8 inspector from [1]. This is the standalone version of the devtools debug protocol. [1] pavelfeldman/v8_inspector@a586f6d
This change introduces experimental v8-inspector support. This brings the DevTools debug protocol allowing Node.js to be debugged with Chrome DevTools native, or through other debuggers supporting that protocol. Partial WebSocket support, to the extent required by DevTools, is included. This is derived from the implementation in Blink. v8-inspector support can be disabled by the --without-inspector configure flag.
Fixes FreeBSD and SmartOS compile errors. Fixes compile issues on Visual Studio 2013 pavelfeldman/v8_inspector@e1bb206
…s is an experimental feature
ofrobots
force-pushed
the
v8-inspector
branch
2 times, most recently
from
09efcf8 to
10c9ffe
Compare
Owner
|
merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses everything but reinterpret casts. Those are currently necessary, but we should reimplement socket using C++, there is no reason to you C there.