This repository was archived by the owner on Jan 26, 2025. It is now read-only.
fix[okta-react-native]: Lock to 0.55.4, add package-lock #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests have started failing (see [Build #699](https://travis-ci.org/okta/okta-oidc-js/builds/401943311)). I tried upgrading the jest and/or the babel plugins, per these threads: facebook/react-native#19859 jestjs/jest#6505 But I didn't have any luck. Locking to the 0.55 series of react-ntaive does seeem to fix this problem
jmelberg-okta
approved these changes
Jul 9, 2018
Contributor
jmelberg-okta
left a comment
jmelberg-okta
left a comment
There was a problem hiding this comment.
Thank you! Can you you create an issue for us to investigate upgrading the jest and/or the babel plugins?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests have started failing (see Build #699).
I tried upgrading the jest and/or the babel plugins, per these threads:
facebook/react-native#19859
jestjs/jest#6505
But I didn't have any luck. Locking to the 0.55 series of react-native does seem to fix this problem for now.