Patch Preact translate bug with patch-package #3504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
package.json
Outdated
| "test:parity-ci": "OKTA_SIW_SKIP_FLAKY=true yarn codegen && run-p -r test:parity-setup test:parity-run", | ||
| "test:parity-ci-flaky": "OKTA_SIW_GEN3=true OKTA_SIW_ONLY_FLAKY=true yarn test:parity-ci" | ||
| "test:parity-ci-flaky": "OKTA_SIW_GEN3=true OKTA_SIW_ONLY_FLAKY=true yarn test:parity-ci", | ||
| "postinstall": "if [[ -z \"$SKIP_POSTINSTALL\" ]]; then patch-package ; fi" |
Contributor
There was a problem hiding this comment.
This command would not work on Windows.
Tried with GitBash and received error "-z was unexpected at this time."
Maybe we can just strip out postinstall command from npm package here (since we don't export Gen3 anyway in npm package, and I hope this fix is temporary)?
Contributor
Author
There was a problem hiding this comment.
Ooh, didn't know about this prepack routine. Good idea, will look into it
denysoblohin-okta
approved these changes
Jan 17, 2024
Contributor
denysoblohin-okta
left a comment
denysoblohin-okta
left a comment
There was a problem hiding this comment.
Please rebase to the latest odyssey-1.x commit.
Should resolve translate="yes" issues in snapshots
trevoring-okta
force-pushed
the
ti-OKTA-684531-patch-preact-translate
branch
from
c1ceca9 to
7cbfa55
Compare
trevoring-okta
added a commit
that referenced
this pull request
Feb 12, 2024
* Patch preact translate bug with patch-package
trevoring-okta
added a commit
that referenced
this pull request
Feb 13, 2024
* Patch preact translate bug with patch-package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
SKIP_POSTINSTALLflag to ayarn installcall which prevents thepostinstallpatch-packagecall from running. This is needed for theverify-package.shscript to work because theyarn installcalls from that script were coming from the installation of the SIW as a dependency for a test app, which was breaking since the test app itself did not havepatch-packageinstalled. The english leak test suite doesn't needpatch-packageanywhere except foryarn installcalls from the package rootPR Checklist
Issue:
Reviewers:
Screenshot/Video:
Highlighted
divwith "Label" is imported from Odyssey and was passedtranslate="no"as a propDownstream Monolith Build: