test: add initial set of unit tests #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Prisma schema in order to generate a valid Prisma client for testing: when the client has not been generated the library throws because it requires the Prisma.dmmf object to exist. A benefit of having a generated client for testing is that we can leverage the generated types to ensure the params being used in the tests are valid. Now that we have @prisma/client in the development setup we can use the official types in the main lib, they won't be used at build time but we can check the types when the development deps are installed. Change the @ts-expect-error above the import of the prisma client to @ts-ignore since during development we no longer expect an error. There is one failing test that has revealed a legitimate bug in modifying deeply nested results. That test has been marked as failing so it does not fail builds.
olivierwilkinson
force-pushed
the
tests
branch
from
d05662e to
2465c93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Prisma schema in order to generate a valid Prisma client for testing: when the client has not been generated the library throws because it requires the Prisma.dmmf object to exist. A benefit of having a generated client for testing is that we can leverage the generated types to ensure the params being used in the tests are valid.
Now that we have @prisma/client in the development setup we can use the official types in the main lib, they won't be used at build time but we can check the types when the development deps are installed. Change the @ts-expect-error above the import of the prisma client to @ts-ignore since during development we no longer expect an error.
There is one failing test which revealed a legitimate bug: it looks like deeply nested results cannot be modified before returning.