Type mismatch for Datepicker props with TS: onChange vs value

[NoahMLoomis]

Awesome tool, just what I was looking for.

There seems to be a type mismatch. The value prop has the following type:

 value: {
        startDate: Date | string,
        endDate: Date | string,
    } | null

But the value passed in the onChange is the following:

value: {
        startDate: string | null,
        endDate: string | null
     }

So when trying to change the value you get the following error:

I'll create a PR for this

[NoahMLoomis]

PR here: #2

[onesine]

Hi @NoahMLoomis 👋.
You are indeed right. I didn't pay attention to that at all. Thank you for the remark and especially for making a PR to correct it.

I am happy to accept your contribution to the project.

I thank you very much and I hope you will be there for other features as the package is young.

[onesine]

@NoahMLoomis
I noticed in your PR you had made these changes.

value: {
    startDate: string | Date,
    endDate: string | Date
} | null,

onChange: (value: {startDate: string | Date, endDate: string | Date} | null) => void

But the values of startDate and endDate should be able to be null. An example would be when you delete the form.

Then it should be

value: {
    startDate: string | Date | null,
    endDate: string | Date | null
} | null,

onChange: (value: {startDate: string | Date | null, endDate: string | Date | null} | null) => void

[onesine]

But I took this into account in the patch for version 1.1.1

[NoahMLoomis]

Awesome! Good catch