Skip to content

Clear transaction id so that on error it clears up #2660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mfbz merged 3 commits into from
Oct 7, 2025
Merged

Clear transaction id so that on error it clears up #2660

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3194b72
Clear transaction id so that on error it clears up
mfbz Oct 7, 2025
deb950c
Added changeset
mfbz Oct 7, 2025
586214a
Merge branch 'master' into mfbz/fix-transaction-button
mfbz Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/upset-sides-wait.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@onflow/react-sdk": minor
---

Fixed transaction management so that it clears up transaction state on error
16 changes: 12 additions & 4 deletions packages/react-sdk/src/provider/GlobalTransactionProvider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,20 @@ export const GlobalTransactionProvider: React.FC<
if (!txId) return

// Subscribe to transaction updates
const unsub = fcl.tx(txId).subscribe(txStatus => {
if (txStatus.status >= TransactionExecutionStatus.EXECUTED) {
// Transaction has been executed, reset the global transaction ID
const unsub = fcl.tx(txId).subscribe(
txStatus => {
if (txStatus.status >= TransactionExecutionStatus.EXECUTED) {
// Transaction has been executed, reset the global transaction ID
setTxId(null)
}
},
error => {
// Handle subscription errors
console.error("Transaction status subscription error:", error)
// Clear the transaction ID to prevent button from staying in processing state
setTxId(null)
}
})
)

return () => {
unsub()
Expand Down