forked from WordPress/wordpress-develop
-
Notifications
You must be signed in to change notification settings - Fork 0
Update to latest trunk #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ootwch
wants to merge
5,211
commits into
ootwch:20221105_no_http_host_pr
Choose a base branch
from
WordPress:trunk
base: 20221105_no_http_host_pr
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5629e3f to
7995c19
Compare
git-svn-id: https://develop.svn.wordpress.org/trunk@61128 602fd350-edb4-49c9-b593-d223f7449a82
git-svn-id: https://develop.svn.wordpress.org/trunk@61129 602fd350-edb4-49c9-b593-d223f7449a82
Applies feedback provided that doing_action would be better check on this situation to avoid developers facing future registration timing issues. Developed in #10452. Props gziolo, jorgefilipecosta, flixos90, mukesh27, jason_the_adams. See #64098. git-svn-id: https://develop.svn.wordpress.org/trunk@61130 602fd350-edb4-49c9-b593-d223f7449a82
The PHPMailer library may automatically switch its encoding based on various internal factors. This commit fixes a bug where the `$phpmailer` global was unintentionally persisting its `Encoding` property from the first `wp_mail()` call to all subsequent calls. This includes unit tests to verify the fix is accurate, and a change to the mock-mailer helper that worked around this bug just-in-time when running the test suite. Props codebuddy, dilip2615, rishabhwp, sajjad67, sirlouen, stephenharris. Fixes #33972. git-svn-id: https://develop.svn.wordpress.org/trunk@61131 602fd350-edb4-49c9-b593-d223f7449a82
MariaDB 10.4 has fallen below 1% usage across all WordPress sites, according to wordpress.org/stats. This 1% threshold was established as the minimum percentage of installs required to be included in the PHPUnit testing matrix in [59587]. Props jorbin. See #63167. git-svn-id: https://develop.svn.wordpress.org/trunk@61132 602fd350-edb4-49c9-b593-d223f7449a82
This commit merges 2 separate translatable strings into 1 (with a translator note) to make its Daylight-Saving-Time-specific context easier to identify & understand. Props jorbin, pbearne, timse201. Fixes #64197. git-svn-id: https://develop.svn.wordpress.org/trunk@61133 602fd350-edb4-49c9-b593-d223f7449a82
Unicode 17 includes 7 new Emoji code points. All 7 were included in Emoji 17, which was officially released in early September 2025. In addition to these 7 new single code point Emoji, Emoji 17 also includes 156 additional Emoji possibilities using modifiers or ZWJ sequences to create various gender and skin tone combinations. “This Emoji update is the best to date by a landslide “ may not be an opinion you hold. Perhaps you’re disappointed, hearing sad trombones in your head . Thankfully, there’s a whole treasure chest of Emoji to choose from (3,953 and counting). But why do I always feel like I'm in The Twilight Zone? And I always feel like somebody's watchin' me? Props westonruter, dd32. Fixes #64184. git-svn-id: https://develop.svn.wordpress.org/trunk@61134 602fd350-edb4-49c9-b593-d223f7449a82
This adds some logic to avoid leaving automated comments with instructions to test in Playground when the pull request has been closed. Props jeffpaul. See #63170. git-svn-id: https://develop.svn.wordpress.org/trunk@61135 602fd350-edb4-49c9-b593-d223f7449a82
…not set. This change is necessary to prevent scanning tools from polluting debug/error logs of some hosting configurations with PHP warnings simply by omitting the Host header from their requests. This commit makes sure that all of the required `host`, `path`, `query`, and `scheme` array keys inside of the `redirect_canonical()` function are always set after various operations have been performed on them. It also includes 1 new test case and 2 additional tests, to verify the problem and its fix are working as intended, as well as a small modification to the `get_canonical()` phpunit helper specifically to account for `HTTP_HOST` maybe not being set. Props artz91, johnjamesjacoby, mindctrl, sirlouen. Fixes #63316. git-svn-id: https://develop.svn.wordpress.org/trunk@61136 602fd350-edb4-49c9-b593-d223f7449a82
… places. This commit updates the `wp_send_user_request()` function so that the updated confirmation key of the request is available to both the confirmation URL and the subsequent filters (specifically `user_request_action_email_content`). This maintains the existing behavior of generating a new key just-in-time before every user request email is sent. Props birgire, dingo_d, garrett-eclipse, johnjamesjacoby. Fixes #44940. git-svn-id: https://develop.svn.wordpress.org/trunk@61137 602fd350-edb4-49c9-b593-d223f7449a82
In [61089], `auth_callback` was added which is causing phpcs to complain about the alignment with the other arguments in the array. Follow-up to [61089] and [61036]. See #64153, #63168. git-svn-id: https://develop.svn.wordpress.org/trunk@61138 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [8196], [32846], [34928]. Props sujansarkar, shailu25, dhruvang21, westonruter, SergeyBiryukov. Fixes #64181. git-svn-id: https://develop.svn.wordpress.org/trunk@61139 602fd350-edb4-49c9-b593-d223f7449a82
Fix function description and add explicit return value typing. Follow-up to [61120]. Props mindctrl, westonruter. See #64108. git-svn-id: https://develop.svn.wordpress.org/trunk@61140 602fd350-edb4-49c9-b593-d223f7449a82
…the filter. Follow-up to [34928], [55693]. See #63166. git-svn-id: https://develop.svn.wordpress.org/trunk@61141 602fd350-edb4-49c9-b593-d223f7449a82
…l when enqueueing assets. Reverts [61126] and [61127], which introduced a bug where the command palette is not stripping numbers. `HTML_Tag_Processor` cannot replace the REGEX yet. Unprops cbravobernal. Follow-up to [61126], [61127]. Props wildworks, tusharaddweb. See #64196. git-svn-id: https://develop.svn.wordpress.org/trunk@61142 602fd350-edb4-49c9-b593-d223f7449a82
Each of these commits during 6.9 only changed blank spaces. Excluding them helps to reduce the noise when doing code archaeology. Follow-up to [60074], [60109], [60664], [60780], [60808], [60816], [61036], [61075], [61087], [61138].o Props jorbin, peterwilsoncc. See #63168. git-svn-id: https://develop.svn.wordpress.org/trunk@61143 602fd350-edb4-49c9-b593-d223f7449a82
Fix an issue where contributors’ notes edits were throttled. Notes are internal and from trusted users, they do not need throttling. Skip calling wp_allow_comment for notes in WP_REST_Comments_Controller::create_item. As a result the pre_comment_approved hook is also not fired for notes. Fixes WordPress/gutenberg#72892 where the issue was originally reported. Props adamsilverstein, desrosj, wildworks, mamaduka. Fixes #64199. git-svn-id: https://develop.svn.wordpress.org/trunk@61144 602fd350-edb4-49c9-b593-d223f7449a82
Fit text did not work after navigating to a page using the Interactivity API router. When users navigated to a post via client-side navigation (e.g., in a Query block with pagination), fit text blocks would not recalculate their font sizes, appearing either too large or too small. This occurred because the fit text initialization only ran on the window.load event, which doesn't fire during client-side navigation. We refactored fit text front end to be an interactivity api first implementation, using an interactivity api init event instead of a window load event. This commit adds the required PHP changes. Props jorgefilipecosta, mukesh27, luisherranz. Fixes #64210. git-svn-id: https://develop.svn.wordpress.org/trunk@61145 602fd350-edb4-49c9-b593-d223f7449a82
Props jorbin, desrosj. See #63165. git-svn-id: https://develop.svn.wordpress.org/trunk@61146 602fd350-edb4-49c9-b593-d223f7449a82
Includes: * Adding the missing `@covers` annotation. * Converting data provider methods to `static` for a slight performance improvement. * Using named data providers. Follow-up to [50130]. Props mukesh27, swissspidy, SergeyBiryukov. See #63167. git-svn-id: https://develop.svn.wordpress.org/trunk@61170 602fd350-edb4-49c9-b593-d223f7449a82
…fset. This adds `is_string()` type checks for the `$post_status` arg passed to both `get_post_status_object()` and `is_post_status_viewable()`. This was triggered by `Tests_Post_IsPostStatusViewable::test_built_in_and_unregistered_status_types()` for the `null` data set. Follow-up to [61170]. See #63167, #63061. git-svn-id: https://develop.svn.wordpress.org/trunk@61171 602fd350-edb4-49c9-b593-d223f7449a82
…lly malformed `post_date`. This commit updates `wp_resolve_post_date()` to use a regular expression for parsing the date string into year, month, and day matches. This approach handles missing leading zeros more reliably than `substr()` while remaining performant (see #57683). It also adds checks and type-casting to `wp_checkdate()` variables before passing them into PHP's `checkdate()` function to avoid the potential for a `TypeError` in PHP 8 and newer (see #54186). Lastly, it includes 2 new unit tests (with data providers) to cover an array of valid and invalid date formats (YYYY-MM-DD, YYYY-MM-DD HH:MM:SS, ISO 8601, RSS, leap years, malformed inputs, etc...) Props alordiel, desrosj, johnbillion, johnjamesjacoby, johnregan3, modius5150, nacin, pbearne. Fixes #26798. git-svn-id: https://develop.svn.wordpress.org/trunk@61172 602fd350-edb4-49c9-b593-d223f7449a82
Dates without leading zeros (e.g., `2012-1-08`, `2012-01-8`) are now correctly recognized as valid dates. This change fixes the test cases to correctly reflect that these formats are valid and fixes an undefined variable reference. Follow-up to [61172]. Props wildworks, westonruter. Fixes #26798. git-svn-id: https://develop.svn.wordpress.org/trunk@61173 602fd350-edb4-49c9-b593-d223f7449a82
…) to preserve CSS cascade. This ensures that on-demand block styles are inserted right after the `wp-block-library` inline style whereas other stylesheets not related to blocks are appended to the end of the `HEAD`. This helps ensure the expected cascade is preserved. If no `wp-block-library` inline style is present, then all styles get appended to the `HEAD` regardless. The handling of the CSS placeholder comment added to the `wp-block-library` inline style is also improved. It is now inserted later to ensure the inline style is printed. Additionally, when the CSS placeholder comment is removed from the `wp-block-library` inline style, the entire `STYLE` tag is now removed if there are no styles left (aside from the `sourceURL` comment). Lastly, the use of the HTML Tag Processor is significantly improved to leverage `WP_HTML_Text_Replacement`. Developed in #10436 Follow-up to [61008]. Props westonruter, peterwilsoncc, dmsnell. Fixes #64099. git-svn-id: https://develop.svn.wordpress.org/trunk@61174 602fd350-edb4-49c9-b593-d223f7449a82
Adds a test for name spacing custom blocks in layout classnames. Props rishabhwp, wildworks, isabel_brison. Fixes #63839. git-svn-id: https://develop.svn.wordpress.org/trunk@61175 602fd350-edb4-49c9-b593-d223f7449a82
… of loading strategy and fetchpriority. This addresses a performance issue in the recursive `WP_Scripts::get_highest_fetchpriority_with_dependents()` and `WP_Scripts::filter_eligible_strategies()` methods for redundant processing of shared dependencies in complex dependency graphs. To fix this, a `$stored_results` param is introduced which is passed by reference; this variable contains a cache of the calculated results for all scripts handles, so that subsequent calls for the same handle can return the cached value instead of re-computing it. Developed in #10459 Follow-up to [60704], [60931], [56033]. Props ciobanucatalin, b1ink0, westonruter, mukesh27. See #61734, #12009. Fixes #64194. git-svn-id: https://develop.svn.wordpress.org/trunk@61176 602fd350-edb4-49c9-b593-d223f7449a82
Changes can be found at https://github.com/WordPress/gutenberg/commits/wp/6.9/. Developed in #10486. See https://make.wordpress.org/core/handbook/about/release-cycle/block-editor-release-process-for-major-releases/#package-updates-and-core-patches. Fixes #64213. Props priethor. git-svn-id: https://develop.svn.wordpress.org/trunk@61177 602fd350-edb4-49c9-b593-d223f7449a82
…of `isset()` ternaries. Developed as a subset of #10654 Initially developed in #4886 Follow-up to [61435], [61434], [61403], [61433], [61432], [61431], [61430], [61429], [61424], [61404], [61403]. Props costdev, westonruter. See #58874, #63430. git-svn-id: https://develop.svn.wordpress.org/trunk@61436 602fd350-edb4-49c9-b593-d223f7449a82
Adds server-side registration for `anchor` block support and its required fields. Props westonruter, wildworks. Fixes #64449. git-svn-id: https://develop.svn.wordpress.org/trunk@61437 602fd350-edb4-49c9-b593-d223f7449a82
This changes WordPress Core's Gutenberg integration from npm packages to checking out and building Gutenberg directly. Instead of syncing individual npm packages, Core now checks out the Gutenberg repository, builds it, and copies the build artifacts. This enables Core to use Gutenberg's advanced features like route-based navigation, full-page rendering, and the Font Library, while also streamlining future updates. New commands: * `npm run gutenberg:checkout` - Clones Gutenberg at a specified ref * `npm run gutenberg:build` - Runs Gutenberg's build process * `npm run gutenberg:copy` - Copies and transforms build output to Core * `npm run gutenberg:integrate` - Runs all three steps Main changes: * Removes webpack configs replaced by Gutenberg's build (blocks.js, packages.js, script-modules.js, development.js, vendors.js) * Adds Font Library page (`/wp-admin/font-library.php`) * Adds copy scripts to transform Gutenberg plugin paths to Core paths * Moves vendor copy step from webpack to Gruntfile New year, new process. Happy New Year! Props youknowriad, ellatrix, sirreal, westonruter, desrosj, tellthemachines. Fixes #64393. git-svn-id: https://develop.svn.wordpress.org/trunk@61438 602fd350-edb4-49c9-b593-d223f7449a82
…-i18n.json handling. This changeset addresses two issues in the Gutenberg integration workflow: * Sets `wpPlugin.name` to `wp` in `build-gutenberg.js` so generated PHP files use `wp_` prefixes instead of `gutenberg_`. * Persists `theme-i18n.json` in the repository for WP-CLI compatibility, as this file is required but was being ignored. Props youknowriad, swissspidy. See #64393. git-svn-id: https://develop.svn.wordpress.org/trunk@61439 602fd350-edb4-49c9-b593-d223f7449a82
`SCRIPT`, `STYLE`, and stylesheet `LINK` tags do not require a type attribute since the HTML5 standard was released in 2008. Removing the type attribute simplifies logic and normalizes the produced HTML content. Developed in #10664. Follow-up to [61411], [46164]. Props jonsurrell, sabernhardt, westonruter. Fixes #64428. See #59883, #64442. git-svn-id: https://develop.svn.wordpress.org/trunk@61440 602fd350-edb4-49c9-b593-d223f7449a82
The purpose of this change is to ensure that the quote block and the quote block cite inherits the text color from the parent block, if: * The parent has a text color set in the block settings, and * The quote block does not have a text color set in the block settings. Follow-up to [43799], [56087]. Props poena, melchoyce, sabernhardt, mukesh27, apermo, SergeyBiryukov. Fixes #51236. git-svn-id: https://develop.svn.wordpress.org/trunk@61441 602fd350-edb4-49c9-b593-d223f7449a82
…ad of `isset()` ternaries. Developed as a subset of #10654 Initially developed in #4886 Follow-up to [61436], [61435], [61434], [61403], [61433], [61432], [61431], [61430], [61429], [61424], [61404], [61403]. Props costdev, westonruter. See #58874, #63430. git-svn-id: https://develop.svn.wordpress.org/trunk@61442 602fd350-edb4-49c9-b593-d223f7449a82
…ead of `isset()` ternaries. Developed as a subset of #10654 Initially developed in #4886 Follow-up to [61442], [61436], [61435], [61434], [61403], [61433], [61432], [61431], [61430], [61429], [61424], [61404], [61403]. Props costdev, westonruter. See #58874, #63430. git-svn-id: https://develop.svn.wordpress.org/trunk@61443 602fd350-edb4-49c9-b593-d223f7449a82
…Use null coalescing operator instead of `isset()` ternaries. Developed as a subset of #10654 Initially developed in #4886 Follow-up to [61443], [61442], [61436], [61435], [61434], [61403], [61433], [61432], [61431], [61430], [61429], [61424], [61404], [61403]. Props costdev, westonruter. See #58874, #63430. git-svn-id: https://develop.svn.wordpress.org/trunk@61444 602fd350-edb4-49c9-b593-d223f7449a82
…ery, General: Use null coalescing operator instead of `isset()` ternaries. Developed as a subset of #10654 Initially developed in #4886 Follow-up to [61444], [61443], [61442], [61436], [61435], [61434], [61403], [61433], [61432], [61431], [61430], [61429], [61424], [61404], [61403]. Props costdev, westonruter. See #58874, #63430. git-svn-id: https://develop.svn.wordpress.org/trunk@61445 602fd350-edb4-49c9-b593-d223f7449a82
Updates the Gutenberg ref to include changes that generate both minified and non-minified CSS files during build. Previously, the build only produced a single CSS file (e.g., `style.css`), causing missing asset errors when `SCRIPT_DEBUG` is set to `false`, as Core expects `.min.css` files. Props peterwilsoncc, dd32, tyxla, jsnajdr, mcsf. Fixes #64393. git-svn-id: https://develop.svn.wordpress.org/trunk@61446 602fd350-edb4-49c9-b593-d223f7449a82
…d` controllers. Follow-up to [30120], [31373]. Props yogeshbhutkar, mikachan, luigipulcini, SergeyBiryukov. Fixes #62696. git-svn-id: https://develop.svn.wordpress.org/trunk@61447 602fd350-edb4-49c9-b593-d223f7449a82
…t_debug()`. This resolves a PHP warning when preparing debug information for the fatal error protection email if `::get_plugin()` returned `false` due to the failing plugin not being found. Follow-up to [46273]. Props mukesh27, afwebdev, abcd95, sainathpoojary, ankitkumarshah, SergeyBiryukov. Fixes #62816. git-svn-id: https://develop.svn.wordpress.org/trunk@61448 602fd350-edb4-49c9-b593-d223f7449a82
…ng to week numbers. See #64224 git-svn-id: https://develop.svn.wordpress.org/trunk@61449 602fd350-edb4-49c9-b593-d223f7449a82
Adds the `--fast` flag to Gutenberg build commands, which skips TypeScript-related steps (version validation, `tsc --build`, and type declaration file checks) that aren't needed when building for WordPress Core. These steps only produce `.d.ts` files which aren't shipped with Core. Also updates the Gutenberg ref to include the commit that adds `--fast` flag support. The build times are now comparable to the build times we had using the npm packages. Props dmsnell, johnbillion. See #64393. git-svn-id: https://develop.svn.wordpress.org/trunk@61450 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [121/tests], [401/tests]. Props salcode, geekofshire, swissspidy, iseulde, miqrogroove, SergeyBiryukov. Fixes #31313. git-svn-id: https://develop.svn.wordpress.org/trunk@61451 602fd350-edb4-49c9-b593-d223f7449a82
Previously, the WP_Block_Processor class was making a mistake in mis-reporting whether a token matches a block type when #innerHTML spans are involved. This patch fixes the logic, which was originally written before a distinction between inner HTML and top-level freeform content was built. Developed in #10701 Discussed in https://core.trac.wordpress.org/ticket/64485 Fixes #64485. git-svn-id: https://develop.svn.wordpress.org/trunk@61452 602fd350-edb4-49c9-b593-d223f7449a82
…sset()` ternaries. Developed as a subset of #10654 Initially developed in #4886 Follow-up to [61445], [61444], [61443], [61442], [61436], [61435], [61434], [61403], [61433], [61432], [61431], [61430], [61429], [61424], [61404], [61403]. Props costdev, westonruter. See #58874, #63430. git-svn-id: https://develop.svn.wordpress.org/trunk@61453 602fd350-edb4-49c9-b593-d223f7449a82
…rator instead of `isset()` ternaries. Developed as a subset of #10654 Initially developed in #4886 Follow-up to [61453], [61445], [61444], [61443], [61442], [61436], [61435], [61434], [61403], [61433], [61432], [61431], [61430], [61429], [61424], [61404], [61403]. Props costdev, westonruter. See #58874, #63430. git-svn-id: https://develop.svn.wordpress.org/trunk@61454 602fd350-edb4-49c9-b593-d223f7449a82
…tead of `isset()` ternaries. Developed as a subset of #10654 Initially developed in #4886 Follow-up to [61454], [61453], [61445], [61444], [61443], [61442], [61436], [61435], [61434], [61403], [61433], [61432], [61431], [61430], [61429], [61424], [61404], [61403]. Props costdev, westonruter. See #58874, #63430. git-svn-id: https://develop.svn.wordpress.org/trunk@61455 602fd350-edb4-49c9-b593-d223f7449a82
…ead of `isset()` ternaries. Developed as a subset of #10654 Initially developed in #4886 Follow-up to [61455], [61454], [61453], [61445], [61444], [61443], [61442], [61436], [61435], [61434], [61403], [61433], [61432], [61431], [61430], [61429], [61424], [61404], [61403]. Props costdev, westonruter. See #58874, #63430. git-svn-id: https://develop.svn.wordpress.org/trunk@61456 602fd350-edb4-49c9-b593-d223f7449a82
… ternaries in remaining core files. Developed as a subset of #10654 Initially developed in #4886 Follow-up to [61456], [61455], [61454], [61453], [61445], [61444], [61443], [61442], [61436], [61435], [61434], [61403], [61433], [61432], [61431], [61430], [61429], [61424], [61404], [61403]. Props costdev, westonruter, jrf, SergeyBiryukov, swissspidy, hellofromTonya, marybaum, oglekler, dmsnell, chaion07, noisysocks, mukesh27. See #63430. Fixes #58874. git-svn-id: https://develop.svn.wordpress.org/trunk@61457 602fd350-edb4-49c9-b593-d223f7449a82
This separates dependency setup from the build process by running the Gutenberg checkout during npm install rather than before each build. Build times decrease by approximately 30 seconds since the checkout now occurs once during installation. Props youknowriad, dmsnell. See #64393. git-svn-id: https://develop.svn.wordpress.org/trunk@61458 602fd350-edb4-49c9-b593-d223f7449a82
Props justlevine, masteradhoc, samiamnot, matt, bradshawtm, 4thhubbard, desrosj, jorbin, westonruter, peterwilsoncc, johnbillion Fixes #62622 git-svn-id: https://develop.svn.wordpress.org/trunk@61459 602fd350-edb4-49c9-b593-d223f7449a82
…ding. Invalid args now cause an `IXR_Error` to be returned. Comprehensive unit tests are also added for the method. Developed in #10690 Follow-up to [1348]. Props josephscott, westonruter. Fixes #64479. git-svn-id: https://develop.svn.wordpress.org/trunk@61460 602fd350-edb4-49c9-b593-d223f7449a82
Updates the Xdebug configuration in the local Docker environment to better support Windows (WSL2) users while maintaining stability for macOS and Linux. * Enables `xdebug.discover_client_host` to allow Xdebug to automatically connect back to the IP address listed in the HTTP request headers, ensuring the debugger works reliably regardless of specific network topology. * Sets `xdebug.client_host` to `host.docker.internal` as a fallback for `xdebug.discover_client_host`. In WSL2 networking, `localhost` resolves to the container itself rather than the host machine, preventing the debugger from connecting to the IDE; `host.docker.internal` correctly routes to the host machine across platforms. Follow-up to [60060]. Props SirLouen, jdeep, westonruter. See #49953. Fixes #63979. git-svn-id: https://develop.svn.wordpress.org/trunk@61461 602fd350-edb4-49c9-b593-d223f7449a82
…)` test. Follow-up to [61336]. See #64224. git-svn-id: https://develop.svn.wordpress.org/trunk@61462 602fd350-edb4-49c9-b593-d223f7449a82
… with `if`/`else` statements. Developed in #10711 Follow-up to [61457], [61456], [61455], [61454], [61453], [61445], [61444], [61443], [61442], [61436], [61435], [61434], [61403], [61433], [61432], [61431], [61430], [61429], [61424], [61404], [61403]. See #58874, #63430. git-svn-id: https://develop.svn.wordpress.org/trunk@61463 602fd350-edb4-49c9-b593-d223f7449a82
…()` ternaries. These had been missed previously due to additional parentheses around the `isset()` expressions. Developed in #10704 Follow-up to [61463], [61457], [61456], [61455], [61454], [61453], [61445], [61444], [61443], [61442], [61436], [61435], [61434], [61403], [61433], [61432], [61431], [61430], [61429], [61424], [61404], [61403]. Props soean. See #58874, #63430. git-svn-id: https://develop.svn.wordpress.org/trunk@61464 602fd350-edb4-49c9-b593-d223f7449a82
… in `wp_setup_nav_menu_item()`. The `get_post_states()` function is also hardened to short-circuit in case a non-`WP_Post` is passed. A test is added to verify this. Developed in #10706 Follow-up to [47211]. Props apedog, josephscott, joemcgill, westonruter. See #49374. Fixes #58932. git-svn-id: https://develop.svn.wordpress.org/trunk@61465 602fd350-edb4-49c9-b593-d223f7449a82
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to latest trunk