Skip to content

Conversation

@ratankaliani
Copy link

Description

Enable kzg-rs feature on revm so KZG point evaluation does not panic by default in the zkVM context.

In Kona, there is an FPVM override for KZG point evaluation (c-kzg is expensive in the FPVM context) to ensure that the executor doesn't panic.

In the zkVM context, we also noticed c-kzg was expensive, so we created a feature to enable the usage kzg-rs in revm (we have an accelerated version of kzg-rs we apply as a patch). This won't impact the FPVM as you override the precompile anyways, but it'd be nice for us to not need to explicitly override the precompile in op-succinct.

Additional context

kzg-rs feature flag in revm

FPVM KZG Point Evaluation
https://github.com/ethereum-optimism/kona/blob/d1b63f8c1f6dba67ef922761e39beb86ddfd5291/bin/client/src/fault/precompiles/kzg_point_eval.rs#L16

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.3%. Comparing base (e58fb96) to head (aa51976).
Report is 1 commits behind head on main.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ratankaliani ratankaliani marked this pull request as draft August 22, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants