feat: enable kzg-rs by default
#450
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable
kzg-rsfeature onrevmso KZG point evaluation does not panic by default in the zkVM context.In Kona, there is an FPVM override for KZG point evaluation (
c-kzgis expensive in the FPVM context) to ensure that the executor doesn't panic.In the zkVM context, we also noticed
c-kzgwas expensive, so we created a feature to enable the usagekzg-rsinrevm(we have an accelerated version ofkzg-rswe apply as a patch). This won't impact the FPVM as you override the precompile anyways, but it'd be nice for us to not need to explicitly override the precompile inop-succinct.Additional context
kzg-rsfeature flag inrevmFPVM KZG Point Evaluation
https://github.com/ethereum-optimism/kona/blob/d1b63f8c1f6dba67ef922761e39beb86ddfd5291/bin/client/src/fault/precompiles/kzg_point_eval.rs#L16