fix: use wildcard values as names #165
Conversation
gustavohenke
left a comment
gustavohenke
left a comment
There was a problem hiding this comment.
Thanks for the PR -- there are a few small things to fix though!
| .map(script => Object.assign({}, { | ||
| command: `npm run ${script}${args}`, | ||
| name: script | ||
| name: (commandInfo.names || '') + script.match(wildcardRegex)[1] |
There was a problem hiding this comment.
The right property is name
| { name: 'w:foo', command: 'npm run watch-foo' }, | ||
| { name: 'w:bar', command: 'npm run watch-bar' }, | ||
| ]); | ||
| }) |
| } | ||
| }); | ||
|
|
||
| expect(parser.parse({ names: 'w:', command: 'npm run watch-*' })).toEqual([ |
There was a problem hiding this comment.
will have to fix the property here too to name (see above)
|
My bad, should be all fixed now :) |
gustavohenke
left a comment
gustavohenke
left a comment
There was a problem hiding this comment.
Thanks for the PR, it looks good.
Now I'm unsure about it, though. #148 doesn't state what the problem actually is.
What you are doing here is reverting the prefixing strategy back to what v3 had -- I'm not sure which style is the preferred one by the users, and might even be a breaking change.
|
|
||
| return this.scripts | ||
| .filter(script => wildcardRegex.test(script)) | ||
| .map(script => Object.assign({}, commandInfo, { |
There was a problem hiding this comment.
I rolled this line back to what it is on master, as some other information will exist on commandInfo
|
Closing as it's fixed by #211. |
3 participants
fix #148