-
Notifications
You must be signed in to change notification settings - Fork 24
Adding technical review doc #223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding technical review doc #223
Conversation
Signed-off-by: Jian Qiu <[email protected]>
Signed-off-by: Jian Qiu <[email protected]>
|
|
||
| * Describe the intended types of organizations who would benefit from adopting this project. (i.e. financial services, any software manufacturer, organizations providing platform engineering services)? | ||
|
|
||
| - Entities, e.g. financial institutions, internet companies, with many Kubernetes clusters. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is OCM tied to any specific market segment? If not, it would be good to mention it here. Maybe we can link here adopters.md file as an example, as you also mention their use cases there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated.
| - [Open-Telemetry](https://github.com/open-cluster-management-io/addon-contrib/tree/main/open-telemetry-addon): OCM | ||
| integrates Open-Telemetry by deploying its operator through an addon, allowing centralized observability and telemetry data | ||
| collection across clusters. | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do I understand it correctly that other projects mentioned in the Adopters.md file are not integrated in a production?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is just a subset of examples, I make some update here to add more examples. Do we need one item for each integration in the adopter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
open-cluster-management-io/ocm#1150 opened for updating the adopters file with other projects integrating with OCM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see that you added adopters file, so it should be good. The main purpose is to showcase how OCM can be used with other projects, so if we list the most common one and rest will be in the adopters file, I think that will be helpful.
|
|
||
| The release process is defined here https://github.com/open-cluster-management-io/community/blob/main/RELEASE.md | ||
|
|
||
| ### Installation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could link the installation guide or Getting Started page here as well or not?: https://open-cluster-management.io/docs/getting-started/quick-start/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
|
|
||
| The project follows the API upgrade flow https://github.com/open-cluster-management-io/api/blob/main/docs/development.md#api-upgrade-flow to rollout from alpha to beta. | ||
| Feature gates from alpha to beta follow a standard lifecycle: | ||
| https://open-cluster-management.io/docs/getting-started/administration/featuregates/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that you skipped Day 2 questions from GTR. Is that because you are applying for Incubation? Or are those questions totally not relevant to your level? If you know the answers for Day 2 questions, I would suggest to include it as well (at least those that are relevant), even when you are only reaching the incubation level just now. It can be helpful later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I am trying to add Day 2 part. Some is marked as TBD since it is not clear to me how to answer or it has not been done yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's mentioned in the template that if it's not applicable, you can put N/A. If it might apply to OCM, but you don't know/not sure, we can raise the question in the #maintainers-circle CNCF slack channel. I think it might help other projects in the future as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated. PTAL again
Signed-off-by: Jian Qiu <[email protected]>
Signed-off-by: Jian Qiu <[email protected]>
|
/hold |
mikeshng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Waiting for Lenka's approval.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mikeshng, qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I think we can go ahead with this one, as this should be a document that will be regularly updated as we progress in the maturity. We can also adjust it based on the questions that the team might get from the TOC. |
|
/unhold |
b803069
into
open-cluster-management-io:main
No description provided.