Skip to content

📖 Fix errors for manifestwork condition rules #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 2 commits into from
Jul 18, 2025
Merged

📖 Fix errors for manifestwork condition rules #499

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a33ace
docs(manifestwork): use manualSelector in Job example to avoid immuta…
zhujian7 Jul 18, 2025
9b99e25
docs(manifestwork): fix celExpressions example to use string array pe…
zhujian7 Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions content/en/docs/concepts/work-distribution/manifestwork.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,14 @@ spec:
name: pi-calculation
namespace: default
spec:
manualSelector: true
Copy link
Member Author

@zhujian7 zhujian7 Jul 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix error:

Failed to apply manifest: Job.batch "pi-calculation" is invalid:
          [spec.selector: Required value, spec.template.metadata.labels: Invalid value:
          map[string]string(nil): `selector` does not match template `labels`, spec.selector:
          Invalid value: "null": field is immutable

selector:
matchLabels:
job: pi-calculation
template:
metadata:
labels:
job: pi-calculation
spec:
containers:
- name: pi
Expand Down Expand Up @@ -263,12 +270,12 @@ manifestConfigs:
- condition: Complete
type: CEL
celExpressions:
- expression: |
object.status.conditions.filter(
c, c.type == 'Complete' || c.type == 'Failed'
).exists(
c, c.status == 'True'
)
- |
Copy link
Member Author

@zhujian7 zhujian7 Jul 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix error:

Error from server (BadRequest): error when creating "cel.yaml": ManifestWork in version "v1" cannot be handled as a ManifestWork: strict decoding error: unknown field "spec.manifestConfigs[0].conditionRules[0].celExpressions[0].expression"

object.status.conditions.filter(
c, c.type == 'Complete' || c.type == 'Failed'
).exists(
c, c.status == 'True'
)
messageExpression: |
result ? "Custom resource is complete" : "Custom resource is not complete"
```
Expand Down