-
Notifications
You must be signed in to change notification settings - Fork 75
update capi cluster registration scenario #516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update capi cluster registration scenario #516
Conversation
✅ Deploy Preview for open-cluster-management ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| namespace: <cluster name> | ||
| type: Opaque | ||
| data: | ||
| values.yaml: <klusterlet helm chart values.yaml | base64> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not quite clear on how this values should be set. Do we have a guideline on how to set this and link here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the values introduction is missing, we need a guideline for the values of clusterManager and klusterlet Helm chart.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a example here ,more description of the fields in the values.yaml have added too.
Signed-off-by: Zhiwei Yin <[email protected]>
5f43910 to
60558ae
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, zhiweiyin318 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2b4cd8b
into
open-cluster-management-io:main
No description provided.