Skip to content

Conversation

@zhiweiyin318
Copy link
Member

No description provided.

@netlify
Copy link

netlify bot commented Oct 11, 2025

Deploy Preview for open-cluster-management ready!

Name Link
🔨 Latest commit 60558ae
🔍 Latest deploy log https://app.netlify.com/projects/open-cluster-management/deploys/68f9e4b1f7c6470008bf791d
😎 Deploy Preview https://deploy-preview-516--open-cluster-management.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@openshift-ci openshift-ci bot requested review from mprahl and qiujian16 October 11, 2025 02:49
namespace: <cluster name>
type: Opaque
data:
values.yaml: <klusterlet helm chart values.yaml | base64>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not quite clear on how this values should be set. Do we have a guideline on how to set this and link here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the values introduction is missing, we need a guideline for the values of clusterManager and klusterlet Helm chart.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a example here ,more description of the fields in the values.yaml have added too.

@qiujian16
Copy link
Member

/approve
/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, zhiweiyin318

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 2b4cd8b into open-cluster-management-io:main Oct 23, 2025
7 checks passed
@zhiweiyin318 zhiweiyin318 deleted the add-capi-cluster branch October 23, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants