Add documentation for AddOnDeploymentConfig namespace behavior #522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for open-cluster-management ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
zhujian7
force-pushed
the
doc-addondeploymentconfig-namespace
branch
from
e2f7b50 to
dc4c5d4
Compare
This commit adds documentation explaining how the agentInstallNamespace field in AddOnDeploymentConfig interacts with the namespace defined in AddOnTemplate manifests. Key points documented: - When AddOnDeploymentConfig is not used, the AddOnTemplate namespace is used - When AddOnDeploymentConfig is used with agentInstallNamespace: "", the AddOnTemplate namespace is used - When AddOnDeploymentConfig is used but agentInstallNamespace is not set, the default "open-cluster-management-agent-addon" is used - When agentInstallNamespace is set to a specific value, that value is used This addresses the behavior fix from open-cluster-management-io/ocm#1209 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> Signed-off-by: zhujian <[email protected]>
zhujian7
force-pushed
the
doc-addondeploymentconfig-namespace
branch
from
dc4c5d4 to
e65084b
Compare
Member
Author
|
/cc @qiujian16 |
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, zhujian7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 2a1db7e
into
open-cluster-management-io:main
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds documentation explaining how the
agentInstallNamespacefield inAddOnDeploymentConfiginteracts with the namespace defined inAddOnTemplatemanifests.Changes
Key Documentation Points
The addon agent installation namespace is determined as follows:
AddOnDeploymentConfigis not used, the namespace fromAddOnTemplateis usedAddOnDeploymentConfigis used withagentInstallNamespace: "", the namespace fromAddOnTemplateis usedAddOnDeploymentConfigis used butagentInstallNamespaceis not set, the defaultopen-cluster-management-agent-addonis usedagentInstallNamespaceis set to a specific namespace, that namespace is usedTest Plan
🤖 Generated with Claude Code