Skip to content

build: migrate to GitHub Actions [BB-7150]#25

Merged
Agrendalath merged 4 commits intomasterfrom
agrendalath/bb-7150-migrate_to_gh_actions
Mar 3, 2023
Merged

build: migrate to GitHub Actions [BB-7150]#25
Agrendalath merged 4 commits intomasterfrom
agrendalath/bb-7150-migrate_to_gh_actions

Conversation

@Agrendalath
Copy link
Copy Markdown
Member

@Agrendalath Agrendalath commented Feb 24, 2023

This:

  1. Adds the suppport for bleach 6.
  2. Adds GitHub workflows.
  3. Adds a template for PRs.
  4. Modernizes setup.py and moves the package version to __init__.py.
  5. Adds pip-tools to logically organize dependencies and allow scheduled requirements updates.
  6. Adds tox to simplify the testing setup.

Review instructions

It will be easier to review this commit by commit.

Testing instructions

  1. Check that the CI is passing.

@Agrendalath Agrendalath force-pushed the agrendalath/bb-7150-migrate_to_gh_actions branch from 76436ce to 14223a2 Compare February 24, 2023 16:35
@Agrendalath Agrendalath self-assigned this Feb 24, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 27, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@0e653d7). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #25   +/-   ##
=========================================
  Coverage          ?   62.65%           
=========================================
  Files             ?        4           
  Lines             ?      166           
  Branches          ?       15           
=========================================
  Hits              ?      104           
  Misses            ?       61           
  Partials          ?        1           
Flag Coverage Δ
unittests 62.65% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Agrendalath Agrendalath marked this pull request as ready for review March 2, 2023 17:46
@Agrendalath Agrendalath force-pushed the agrendalath/bb-7150-migrate_to_gh_actions branch 2 times, most recently from fb607db to b22ad29 Compare March 2, 2023 18:01
Copy link
Copy Markdown
Member

@navinkarkera navinkarkera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • I tested this: (CI is passing)
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation
  • I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository.

@Agrendalath Agrendalath force-pushed the agrendalath/bb-7150-migrate_to_gh_actions branch from b22ad29 to 908b15a Compare March 3, 2023 17:16
@Agrendalath Agrendalath merged commit 60e3f65 into master Mar 3, 2023
@Agrendalath Agrendalath deleted the agrendalath/bb-7150-migrate_to_gh_actions branch March 3, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants