Skip to content

chore: Use TestContainers instead of github services / docker for e2e tests #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
toddbaert merged 7 commits into from
Apr 21, 2025
Merged

chore: Use TestContainers instead of github services / docker for e2e tests #345

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
37be781
Initial add test containers for Flagd E2E tests
kylejuliandev Apr 11, 2025
da614ac
Tidy up test hooks and ensure hostname is pulled from docker
kylejuliandev Apr 16, 2025
38307eb
Refactor to ensure Provider is set in the same context as client
kylejuliandev Apr 16, 2025
21edab4
Ensure E2E skip is enabled for Flagd tests
kylejuliandev Apr 16, 2025
ee25cfa
Remove services in e2e ci pipeline
kylejuliandev Apr 16, 2025
f5145b2
fixup: dont use sync-testbed
toddbaert Apr 21, 2025
cf40717
Merge branch 'main' into feat/add-testcontainers
toddbaert Apr 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup: dont use sync-testbed 
Signed-off-by: Todd Baert <[email protected]>
  • Loading branch information
@toddbaert
toddbaert committed Apr 21, 2025
commit f5145b2fe43bb6791a1a8a9cbcf23a42f8ac7fcb
17 changes: 0 additions & 17 deletions src/OpenFeature.Contrib.Providers.Flagd/docker-compose.yaml
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions test/OpenFeature.Contrib.Providers.Flagd.E2e.ProcessTest/FlagdSyncTestBedContainer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ public class FlagdSyncTestBedContainer
public FlagdSyncTestBedContainer()
{
Container = new ContainerBuilder()
.WithImage("ghcr.io/open-feature/sync-testbed:v0.5.6")
.WithPortBinding(9090, true)
.WithImage("ghcr.io/open-feature/flagd-testbed:v0.5.21")
.WithPortBinding(8015, true)
.Build();
}
}
Expand Down
2 changes: 1 addition & 1 deletion ...Feature.Contrib.Providers.Flagd.E2e.ProcessTest/Steps/EvaluationStepDefinitionsProcess.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ public class EvaluationStepDefinitionsProcess : EvaluationStepDefinitionsBase
static EvaluationStepDefinitionsProcess()
{
var host = TestHooks.FlagdSyncTestBed.Container.Hostname;
var port = TestHooks.FlagdSyncTestBed.Container.GetMappedPublicPort(9090);
var port = TestHooks.FlagdSyncTestBed.Container.GetMappedPublicPort(8015);

var flagdProvider = new FlagdProvider(
FlagdConfig.Builder()
Expand Down
2 changes: 1 addition & 1 deletion .../OpenFeature.Contrib.Providers.Flagd.E2e.ProcessTest/Steps/FlagdStepDefinitionsProcess.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ public class FlagdStepDefinitionsProcess : FlagdStepDefinitionsBase
static FlagdStepDefinitionsProcess()
{
var host = TestHooks.FlagdSyncTestBed.Container.Hostname;
var port = TestHooks.FlagdSyncTestBed.Container.GetMappedPublicPort(9090);
var port = TestHooks.FlagdSyncTestBed.Container.GetMappedPublicPort(8015);

var flagdProvider = new FlagdProvider(
FlagdConfig.Builder()
Expand Down
4 changes: 2 additions & 2 deletions ...lagd.E2e.RpcTest/FlagdTestBedContainer.cs → ...d.E2e.RpcTest/FlagdRpcTestBedContainer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@

namespace OpenFeature.Contrib.Providers.Flagd.E2e.RpcTest
{
public class FlagdTestBedContainer
public class FlagdRpcTestBedContainer
{
public IContainer Container { get; }

public FlagdTestBedContainer()
public FlagdRpcTestBedContainer()
{
Container = new ContainerBuilder()
.WithImage("ghcr.io/open-feature/flagd-testbed:v0.5.21")
Expand Down
4 changes: 2 additions & 2 deletions test/OpenFeature.Contrib.Providers.Flagd.E2e.RpcTest/Steps/TestHooks.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,12 @@ namespace OpenFeature.Contrib.Providers.Flagd.E2e.RpcTest.Steps
[Binding]
public class TestHooks
{
public static FlagdTestBedContainer FlagdTestBed { get; private set; }
public static FlagdRpcTestBedContainer FlagdTestBed { get; private set; }

[BeforeTestRun]
public static async Task StartContainerAsync()
{
FlagdTestBed = new FlagdTestBedContainer();
FlagdTestBed = new FlagdRpcTestBedContainer();

await FlagdTestBed.Container.StartAsync();
}
Expand Down