test: Adopt good async practices in Flagd E2E integration tests #403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kyle Julian <[email protected]>
askpt
approved these changes
May 12, 2025
weyert
pushed a commit
to weyert/dotnet-sdk-contrib
that referenced
this pull request
May 30, 2025
…-feature#403) Signed-off-by: Kyle Julian <[email protected]> Co-authored-by: André Silva <[email protected]> Signed-off-by: Weyert de Boer <[email protected]>
weyert
pushed a commit
to weyert/dotnet-sdk-contrib
that referenced
this pull request
Jun 19, 2025
…-feature#403) Signed-off-by: Kyle Julian <[email protected]> Co-authored-by: André Silva <[email protected]>
weyert
pushed a commit
to weyert/dotnet-sdk-contrib
that referenced
this pull request
Jun 19, 2025
…-feature#403) Signed-off-by: Kyle Julian <[email protected]> Co-authored-by: André Silva <[email protected]> Signed-off-by: Weyert de Boer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
ConfigureAwait(false)- less important in the tests but best to keep things consistentRelated Issues
Related to #345 and #356
Notes
Follow-up Tasks
How to test