Skip to content

chore: Makefile full schema versioning #1321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
toddbaert wants to merge 2 commits into from
Closed

chore: Makefile full schema versioning #1321

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb4e2dc
chore: Makefile full schema versioning
toddbaert May 27, 2024
8972336
Update Makefile
toddbaert May 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
PHONY: .docker-build .build .run .mockgen
PREFIX=/usr/local
PUBLIC_JSON_SCHEMA_DIR=docs/schema/v0/
JSON_SCHEMA_VERSION=v0.2.3
PUBLIC_JSON_SCHEMA_DIR=docs/schema/$(JSON_SCHEMA_VERSION)/
ALL_GO_MOD_DIRS := $(shell find . -type f -name 'go.mod' -exec dirname {} \; | sort)

FLAGD_DEV_NAMESPACE ?= flagd-dev
Expand Down Expand Up @@ -116,7 +117,7 @@ markdownlint-fix:

.PHONY: pull-schemas-submodule
pull-schemas-submodule:
git submodule update schemas
cd schemas/ && git checkout json/json-schema-$(JSON_SCHEMA_VERSION)

.PHONY: generate-proto-docs
generate-proto-docs: pull-schemas-submodule
Expand All @@ -125,11 +126,12 @@ generate-proto-docs: pull-schemas-submodule
&& sed '/^## Table of Contents/,/#top/d' ${PWD}/$(DOCS_DIR)/reference/specifications/protos-with-toc.md >> ${PWD}/$(DOCS_DIR)/reference/specifications/protos.md \
&& rm -f ${PWD}/$(DOCS_DIR)/reference/specifications/protos-with-toc.md

# Update the schema at flagd.dev
# PUBLIC_JSON_SCHEMA_DIR above controls the dir (and therefore major version)
# update or add the publicly served schema at https://flagd.dev/schema/${JSON_SCHEMA_VERSION}/flags.json
# update JSON_SCHEMA_VERSION var at the top of this file with the version to be updated or added and served publicly
.PHONY: update-public-schema
update-public-schema: pull-schemas-submodule
rm -f $(PUBLIC_JSON_SCHEMA_DIR)*.json
rm -rf ./$(PUBLIC_JSON_SCHEMA_DIR) || true
mkdir ./$(PUBLIC_JSON_SCHEMA_DIR)
cp schemas/json/*.json $(PUBLIC_JSON_SCHEMA_DIR)

.PHONY: run-web-docs
Expand Down