Skip to content

fix: make goff url for web configurable #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukas-reining merged 1 commit into from
Apr 21, 2024
Merged

fix: make goff url for web configurable #287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docker-compose.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ services:
- OTEL_EXPORTER_JAEGER_AGENT_HOST=jaeger
- OTEL_EXPORTER_JAEGER_AGENT_PORT=6832
- GO_FEATURE_FLAG_URL=http://go-feature-flag:1031
- GO_FEATURE_FLAG_WEB_URL=http://localhost:1031
- FIB_SERVICE_URL=http://fib-service:30001
- FIB_SERVICE_USER
- FIB_SERVICE_PASS
Expand Down
5 changes: 3 additions & 2 deletions packages/provider/src/lib/provider.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,14 +113,14 @@ export class ProviderService {
new GoFeatureFlagProvider({
endpoint: process.env.GO_FEATURE_FLAG_URL as string,
}),
available: () => !!process.env.GO_FEATURE_FLAG_URL,
available: () => !!process.env.GO_FEATURE_FLAG_WEB_URL,
},
[GO_OFREP_PROVIDER_ID]: {
factory: () => {
return new OFREPProvider({ baseUrl: process.env.GO_FEATURE_FLAG_URL as string });
},
available: () => !!process.env.GO_FEATURE_FLAG_URL,
url: process.env.GO_FEATURE_FLAG_URL as string
url: process.env.GO_FEATURE_FLAG_WEB_URL as string
},
[FLAGSMITH_PROVIDER_ID]: {
factory: () => {
Expand Down Expand Up @@ -205,6 +205,7 @@ export class ProviderService {
host: p[1].host,
port: p[1].port,
tls: p[1].tls,
url: p[1].url
};
});
}
Expand Down