Skip to content

Conversation

@xin-li-67
Copy link
Contributor

Motivation

Translate docs/en/understand_mmcv/data_transform.ed.

Modification

modified: docs/en/get_started/build.md
modified: docs/en/get_started/introduction.md
modified: docs/en/understand_mmcv/cnn.md
modified: docs/en/understand_mmcv/data_process.md
modified: docs/zh_cn/understand_mmcv/data_transform.md
modified: docs/en/understand_mmcv/data_transform.md

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

@xin-li-67
Copy link
Contributor Author

Reopened this pr. BTW, seems like there is an issue related to flake8 in the ci script.

@zhouzaida
Copy link
Collaborator

Hi, you can merge the upstream master to fix the flake8 error which was fixed by #2328

@zhouzaida zhouzaida requested review from C1rN09 and mzr1996 October 11, 2022 06:43
@zhouzaida zhouzaida added the 2.x label Oct 16, 2022
Copy link
Collaborator

@C1rN09 C1rN09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhouzaida zhouzaida merged commit c9ed3f5 into open-mmlab:2.x Oct 20, 2022
@xin-li-67 xin-li-67 deleted the data_transform_en branch October 21, 2022 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants