Skip to content

Conversation

@DanieeelLiu
Copy link
Contributor

Modification

  1. Delete mmcv/ops/csrc/common/mlu/psamask_mlu_kernel.mlu.
  2. Delete mmcv/ops/csrc/common/mlu/psamask_utils.hpp.
  3. Modify mmcv/ops/csrc/pytorch/mlu/psamask_mlu.cpp.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

@zhouzaida zhouzaida added the MLU label May 30, 2023
@zhouzaida zhouzaida changed the title [Feature] Replace the implementation of psa_mask with mlu-ops. [Refactor] Replace the implementation of psa_mask with mlu-ops. May 31, 2023
@zhouzaida zhouzaida merged commit 92b3e86 into open-mmlab:main May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants