Skip to content

Conversation

@shun001
Copy link
Contributor

@shun001 shun001 commented Oct 18, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

fix deform_conv.py for torch_npu v2.1.

Modification

fix deform_conv.py for torch_npu v2.1.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
No.

Use cases (Optional)

The verification has been performed on the npu device.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

@Ginray
Copy link
Contributor

Ginray commented Oct 24, 2023

/lgtm

@zhouzaida zhouzaida changed the title [fix] fix deform_conv.py for torch_npu v2.1 [Fix] Fix deform_conv.py for torch_npu v2.1 Oct 24, 2023
@zhouzaida zhouzaida merged commit 00e92ab into open-mmlab:main Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants