Allow NULL arrays for empty datatypes. #1121
Conversation
When building an empty datatype (aka. size = 0) because the count of included datatypes is 0, be less strict on what the arguments are (allow NULL pointers). (cherry picked from commit open-mpi/ompi@6e6ed62)
Signed-off-by: Jeff Squyres <[email protected]>
|
Test PASSed. |
|
Test PASSed. |
|
This is the cherry-pick from master. This particular commit looks OK but I noticed something strange while looking at the code. In 1.10 the MPI_Type_hindexed explicitly calls MPI_Type_create_hindexed. I was under the impression that we were trying to never call an MPI function from inside the library. |
|
@bosilca Good catch. Looks like we have fixed this kind of thing for the v2.0.0 release -- there's a handful of MPI functions that turn around and call other MPI functions (E.g., MPI_ERRHANDLER_GET calls MPI_COMM_GET_ERRHANDLER). In master/v2.x, they actually call the PMPI equivalents, so that we at least don't trigger tools improperly. But other than that, it sounds like you're cool with the cherry pick: 👍 |
5 participants
When building an empty datatype (aka. size = 0) because the count of
included datatypes is 0, be less strict on what the arguments are
(allow NULL pointers).
(cherry picked from commit open-mpi/ompi@6e6ed62)
@bosilca Please review. Straightforward cherry-pick from master.