Switch back to original conftest test --update behavior
#1138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jalseth
approved these changes
Jun 7, 2025
jalseth
requested changes
Jun 7, 2025
In conftest v0.61.0 the behavior of --update changed in order to fetch the policy URLs and stored them in a temporary directory. It broke the previous behavior that updated current policy directory and instead aggregated the current policy (under `policy`) with the one(s) used in `--update`. It also broke the behavior of a project that had no existing `policy`. This reverts commit ed0ff0a. Fixes #1136. Signed-off-by: Leonardo Taccari <[email protected]>
Add an acceptance test in order to ensure that: - conftest test --update create/populate policy directory - conftest test --update update the policy directory with the now policies that are fetched remotely Fixes #1136. Signed-off-by: Leonardo Taccari <[email protected]>
|
Whoops, sorry. I have tested directly only that bats.test and I set
I have just adjusted it in order to always refers to absolute paths and avoiding the (I have retested locally to also verify that and I hope this time should be fine!) Thanks James! |
|
PS: I've also rebased to latest |
jalseth
approved these changes
Jun 10, 2025
|
Thank you very much James! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In conftest v0.61.0 the behavior of --update changed in order to fetch the policy URLs and stored them in a temporary directory.
It broke the previous behavior that updated current policy directory and instead aggregated the current policy (under
policy) with the one(s) used in--update.It also broke the behavior of a project that had no existing
policy.This reverts commit ed0ff0a.
Fixes #1136.
I have also added corresponding acceptance tests in order to exercise such behavior.
Please note that #1106 maybe needs to be reopened and/or inspected again. I have mostly focused on resurrecting the old behavior because the current one broke all my conftest usecases and maybe it will be the same for other folks.
If this change is okay I think it would be nice to also tag a
0.61.10.61.2 release in order to avoid that regression.Thanks a lot!