Skip to content

Conversation

@Kielek
Copy link
Member

@Kielek Kielek commented Aug 9, 2023

Propagate changes from open-telemetry/opentelemetry-dotnet#4757

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • [ ] Appropriate CHANGELOG.md updated for non-trivial changes
  • [ ] Design discussion issue #
  • [ ] Changes in public API reviewed

@Kielek Kielek marked this pull request as ready for review August 9, 2023 15:00
@Kielek Kielek requested a review from a team August 9, 2023 15:00
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #1300 (75bdd90) into main (e0eeb0a) will increase coverage by 0.30%.
Report is 9 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1300      +/-   ##
==========================================
+ Coverage   73.83%   74.13%   +0.30%     
==========================================
  Files         264      256       -8     
  Lines        9386     9345      -41     
==========================================
- Hits         6930     6928       -2     
+ Misses       2456     2417      -39     
Files Changed Coverage Δ
...ry.Exporter.Geneva/TLDExporter/TldTraceExporter.cs 32.31% <ø> (ø)
...on.AWS/Implementation/AWSTracingPipelineHandler.cs 87.75% <ø> (ø)
...tion.AWS/Implementation/SnsRequestContextHelper.cs 95.00% <ø> (ø)
...tion.AWS/Implementation/SqsRequestContextHelper.cs 95.00% <ø> (ø)
...ntation.AWSLambda/Implementation/AWSLambdaUtils.cs 81.57% <ø> (ø)
...ResourceDetectors.Azure/AzureVmMetadataResponse.cs 94.28% <ø> (ø)
src/OpenTelemetry.Sampler.AWS/RateLimiter.cs 100.00% <ø> (ø)
...c/OpenTelemetry.Sampler.AWS/RateLimitingSampler.cs 100.00% <ø> (ø)
...Lambda/Implementation/AWSLambdaResourceDetector.cs 100.00% <100.00%> (ø)
...ation.AWSLambda/TracerProviderBuilderExtensions.cs 100.00% <100.00%> (ø)
... and 1 more

... and 8 files with indirect coverage changes

@CodeBlanch
Copy link
Member

@Kielek FYI I did a more thorough fix on open-telemetry/opentelemetry-dotnet#4759. Fixing the SDK to 7.0.306 is fine to unblock things but ultimately this will have to be solved before jumping to .NET 8 SDK 😄

@utpilla
Copy link
Contributor

utpilla commented Aug 9, 2023

@Kielek FYI I did a more thorough fix on open-telemetry/opentelemetry-dotnet#4759. Fixing the SDK to 7.0.306 is fine to unblock things but ultimately this will have to be solved before jumping to .NET 8 SDK 😄

Fixed it in #1301

@utpilla utpilla closed this Aug 9, 2023
@Kielek Kielek deleted the use-net-sdk-7.0.306 branch August 10, 2023 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants