-
Notifications
You must be signed in to change notification settings - Fork 362
[release] core-1.10.0 release updates #2317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
057df3d
e826832
7d7dda5
c3b3578
1521dbe
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -59,8 +59,10 @@ public override void RecordException(Exception exception, Attributes? attributes | |
|
|
||
| var tags = attributes != null ? new TagList(attributes.AllAttributes.ToArray()) : default; | ||
|
|
||
| this.activity.RecordException(exception, tags); | ||
| this.activity.AddException(exception, tags); | ||
| #pragma warning disable CS0618 // Type or member is obsolete | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Where something was calling
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Exception made in
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. #2321 created |
||
| this.activity.SetStatus(Status.Error.WithDescription(exception.Message)); | ||
| #pragma warning restore CS0618 // Type or member is obsolete | ||
| } | ||
|
|
||
| public override void End() | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where something was calling
ActivityExtensions.RecordExceptionI switched it to callActivity.AddExceptionbecauseActivity.AddExceptiondoes the same job (add event matching exception semantic conventions), no migration necessary.